From: Thomas Gleixner <tglx@linutronix.de>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com,
hpa@zytor.com
Subject: Re: [v1 0/9] Early boot time stamps for x86
Date: Thu, 23 Mar 2017 19:40:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703231933480.3982@nanos> (raw)
In-Reply-To: <0a628969-e4f6-a463-04e5-889e7b423602@oracle.com>
On Thu, 23 Mar 2017, Pasha Tatashin wrote:
> I will add a condition to tsc_early_init() to check for TSC_ADJUST if it is
> not 0, disable early TSC feature. Does this sound OK?
Not really.
I have strong objections against how this is crammed into the early boot
process along with the code duplication and the extra magic which is
caused by this.
The early boot process is fragile enough, so we really only want to have
code there which is absolutely required. That timestamp feature does not
qualify for that at all.
I need some quiet time to look into that, so please don't waste too much
time on refactoring that patch set.
Thanks,
tglx
prev parent reply other threads:[~2017-03-23 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 20:24 Pavel Tatashin
2017-03-22 20:24 ` [v1 1/9] sched/clock: broken stable to unstable transfer Pavel Tatashin
2017-03-27 10:27 ` [tip:sched/urgent] sched/clock: Fix " tip-bot for Pavel Tatashin
2017-03-22 20:24 ` [v1 2/9] sched/clock: interface to allow timestamps early in boot Pavel Tatashin
2017-03-22 20:24 ` [v1 3/9] x86/cpu: determining x86 vendor early Pavel Tatashin
2017-03-22 20:24 ` [v1 4/9] x86/tsc: early MSR-based CPU/TSC frequency discovery Pavel Tatashin
2017-03-22 20:24 ` [v1 5/9] x86/tsc: disable early messages from quick_pit_calibrate Pavel Tatashin
2017-03-22 20:24 ` [v1 6/9] x86/tsc: use cpuid to determine TSC frequency Pavel Tatashin
2017-03-22 20:24 ` [v1 7/9] x86/tsc: use cpuid to determine CPU frequency Pavel Tatashin
2017-03-22 20:24 ` [v1 8/9] x86/tsc: tsc early Pavel Tatashin
2017-03-24 5:38 ` kbuild test robot
2017-03-22 20:24 ` [v1 9/9] x86/tsc: use " Pavel Tatashin
2017-03-22 20:27 ` [v1 0/9] Early boot time stamps for x86 Peter Zijlstra
2017-03-23 0:02 ` Pasha Tatashin
2017-03-22 20:28 ` Peter Zijlstra
2017-03-22 23:59 ` Pasha Tatashin
2017-03-23 10:56 ` Thomas Gleixner
2017-03-23 14:39 ` Pasha Tatashin
2017-03-23 18:40 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703231933480.3982@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®