From: Thomas Gleixner <tglx@linutronix.de>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, linux-kernel@vger.kernel.org,
tipbuild@zytor.com
Subject: Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error: '__NR_ia32_execve' undeclared
Date: Fri, 31 Mar 2017 09:25:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1703310901580.1780@nanos> (raw)
In-Reply-To: <e5b97751-bb8f-08d0-35c8-b7e1e9100b01@virtuozzo.com>
On Thu, 30 Mar 2017, Dmitry Safonov wrote:
> > vim +/__NR_ia32_execve +541 arch/x86/kernel/process_64.c
> >
> > 535 set_thread_flag(TIF_IA32);
> > 536 clear_thread_flag(TIF_X32);
> > 537 if (current->mm)
> > 538 current->mm->context.ia32_compat = TIF_IA32;
> > 539 current->personality |= force_personality32;
> > 540 /* Prepare the first "return" to user space */
> > > 541 task_pt_regs(current)->orig_ax = __NR_ia32_execve;
> > 542 current->thread.status |= TS_COMPAT;
> > 543 #endif
> > 544 }
>
> There was this chunk in the patch, maybe it could be done nicer,
> but I didn't find the nicer way.
> I checked it compilation/work with(out) ia32/x32/64-bit configs
> before sending.
Yeah, I know and it's just crap. WTF is wrong with:
#ifdef CONFIG_IA32_EMULATION
#include <asm/unistd_32_ia32.h>
#endif
It's not rocket science, really.
Thanks,
tglx
next prev parent reply other threads:[~2017-03-31 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 9:31 kbuild test robot
2017-03-30 9:45 ` Dmitry Safonov
2017-03-31 7:25 ` Thomas Gleixner [this message]
2017-03-31 10:08 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703310901580.1780@nanos \
--to=tglx@linutronix.de \
--cc=dsafonov@virtuozzo.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tipbuild@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®