mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild test robot <fengguang.wu@intel.com>, <kbuild-all@01.org>,
	<linux-kernel@vger.kernel.org>, <tipbuild@zytor.com>
Subject: Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error: '__NR_ia32_execve' undeclared
Date: Thu, 30 Mar 2017 12:45:51 +0300	[thread overview]
Message-ID: <e5b97751-bb8f-08d0-35c8-b7e1e9100b01@virtuozzo.com> (raw)
In-Reply-To: <201703301754.uKyz1CYf%fengguang.wu@intel.com>

On 03/30/2017 12:31 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/mm
> head:   693bcce23a1f830d64480cad10f4004e520965fd
> commit: 693bcce23a1f830d64480cad10f4004e520965fd [1/1] x86/mm: Make in_compat_syscall() work during exec
> config: x86_64-randconfig-x012-201713 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 693bcce23a1f830d64480cad10f4004e520965fd
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>    arch/x86/kernel/process_64.c: In function '__set_personality_ia32':
>>> arch/x86/kernel/process_64.c:541:35: error: '__NR_ia32_execve' undeclared (first use in this function)
>      task_pt_regs(current)->orig_ax = __NR_ia32_execve;
>                                       ^~~~~~~~~~~~~~~~
>    arch/x86/kernel/process_64.c:541:35: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +/__NR_ia32_execve +541 arch/x86/kernel/process_64.c
>
>    535		set_thread_flag(TIF_IA32);
>    536		clear_thread_flag(TIF_X32);
>    537		if (current->mm)
>    538			current->mm->context.ia32_compat = TIF_IA32;
>    539		current->personality |= force_personality32;
>    540		/* Prepare the first "return" to user space */
>  > 541		task_pt_regs(current)->orig_ax = __NR_ia32_execve;
>    542		current->thread.status |= TS_COMPAT;
>    543	#endif
>    544	}

There was this chunk in the patch, maybe it could be done nicer,
but I didn't find the nicer way.
I checked it compilation/work with(out) ia32/x32/64-bit configs
before sending.

--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -486,6 +486,10 @@ __switch_to(struct task_struct *prev_p, struct 
task_struct *next_p)
  	return prev_p;
  }

+#define __NR_execve		59
+#define __NR_x32_execve		520
+#define __NR_ia32_execve	11
+
  void set_personality_64bit(void)

  reply	other threads:[~2017-03-30  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  9:31 kbuild test robot
2017-03-30  9:45 ` Dmitry Safonov [this message]
2017-03-31  7:25   ` Thomas Gleixner
2017-03-31 10:08     ` Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b97751-bb8f-08d0-35c8-b7e1e9100b01@virtuozzo.com \
    --to=dsafonov@virtuozzo.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tipbuild@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®