From: Thomas Gleixner <tglx@linutronix.de>
To: Aniruddha Banerjee <aniruddhab@nvidia.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default
Date: Fri, 31 Mar 2017 10:01:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1703310953520.1780@nanos> (raw)
In-Reply-To: <fe0774b2000848a6bd065efc649c6eab@bgmail102.nvidia.com>
On Thu, 30 Mar 2017, Aniruddha Banerjee wrote:
> add IRQF_TRIGGER_MASK on PPI by default so that the PPIs are
> not configured as edge-triggered, which may be wrong for certain GIC
> implementations such as the GIC-400
The above is just useless blurb.
I can't figure out at all WHY a generic interface has anything to do with
edge trigger configuration.
I assume this is (Nvidia) GIC specific nonsense, so why are you inflicting
this on every caller of this interface unconditionally w/o explaining what
the impact of this change might be and why it does not cause havoc for any
existing caller?
This is function is implemented in kernel/irq/ not in foo/gic/ so you
better come up with some coherent explanation.
Thanks,
tglx
next prev parent reply other threads:[~2017-03-31 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 19:46 Aniruddha Banerjee
2017-03-31 8:01 ` Thomas Gleixner [this message]
2017-03-31 8:13 ` Jon Hunter
2017-03-31 8:16 ` Marc Zyngier
2017-03-31 12:07 ` Aniruddha Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703310953520.1780@nanos \
--to=tglx@linutronix.de \
--cc=aniruddhab@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®