From: Chandra Annamaneni <chandra627@gmail.com>
To: chandrasekhar annamaneni <chandra627@gmail.com>
Cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function name
Date: Fri, 21 Apr 2017 00:40:25 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1704210039130.21893@panther> (raw)
In-Reply-To: <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3244 bytes --]
Third Reminder. Please review.
--
Chandra
On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
>
> Second reminder, please review.
>
> Thanks.
> Chandra
>
>
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> wrote:
>
> Change video.c to use %s, __func__ instead of function names.
> Warnings flagged by checkpatch.pl
>
> Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
>
> diff --git a/drivers/staging/most/aim-v4l2/video.c
> b/drivers/staging/most/aim-v4l2/video.c
> index e074841..59e861e 100644
> --- a/drivers/staging/most/aim-v4l2/video.c
> +++ b/drivers/staging/most/aim-v4l2/video.c
> @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> struct most_video_dev *mdev = video_drvdata(filp);
> struct aim_fh *fh;
>
> - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
> switch (vdev->vfl_type) {
> case VFL_TYPE_GRABBER:
> @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
> struct most_video_dev *mdev = fh->mdev;
> struct mbo *mbo, *tmp;
>
> - v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
> + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
> /*
> * We need to put MBOs back before we call
> most_stop_channel()
> @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file,
> void *priv, v4l2_std_id *norm)
> struct aim_fh *fh = priv;
> struct most_video_dev *mdev = fh->mdev;
>
> - v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
> + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
> *norm = V4L2_STD_UNKNOWN;
> return 0;
> @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
> void *priv, unsigned int index)
> struct aim_fh *fh = priv;
> struct most_video_dev *mdev = fh->mdev;
>
> - v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n",
> index);
> + v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
>
> if (index >= V4L2_AIM_MAX_INPUT)
> return -EINVAL;
> @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
> most_video_dev *mdev)
> {
> int ret;
>
> - v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
> + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
> init_waitqueue_head(&mdev->wait_data);
>
> @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
> most_video_dev *mdev)
>
> static void aim_unregister_videodev(struct most_video_dev
> *mdev)
> {
> - v4l2_info(&mdev->v4l2_dev,
> "aim_unregister_videodev()\n");
> + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
>
> video_unregister_device(mdev->vdev);
> }
>
>
>
>
next prev parent reply other threads:[~2017-04-21 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 19:49 Chandra Annamaneni
[not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
2017-04-10 11:21 ` Christian Gromm
2017-04-21 7:40 ` Chandra Annamaneni [this message]
2017-04-21 8:40 ` Greg KH
2017-04-21 18:06 ` Chandra Annamaneni
2017-04-21 18:19 ` Greg KH
2017-04-25 6:20 ` Chandra Annamaneni
2017-04-25 18:36 ` Greg KH
2017-04-26 2:28 ` Chandra Annamaneni
2017-04-26 2:55 ` Joe Perches
2017-04-21 10:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704210039130.21893@panther \
--to=chandra627@gmail.com \
--cc=andrey.shvetsov@k2l.de \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®