mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chandra Annamaneni <chandra627@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Chandra Annamaneni <chandra627@gmail.com>,
	devel@driverdev.osuosl.org, christian.gromm@microchip.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function name
Date: Mon, 24 Apr 2017 23:20:22 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.1704242318590.23632@panther> (raw)
In-Reply-To: <20170421181946.GA21863@kroah.com>


    Change video.c to use %s, __func__ instead of function names.
    Warnings flagged by checkpatch.pl
    
    Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>

diff --git a/drivers/staging/most/aim-v4l2/video.c 
b/drivers/staging/most/aim-v4l2/video.c
index e074841..59e861e 100644
--- a/drivers/staging/most/aim-v4l2/video.c
+++ b/drivers/staging/most/aim-v4l2/video.c
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
        struct most_video_dev *mdev = video_drvdata(filp);
        struct aim_fh *fh;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        switch (vdev->vfl_type) {
        case VFL_TYPE_GRABBER:
@@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
        struct most_video_dev *mdev = fh->mdev;
        struct mbo *mbo, *tmp;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        /*
         * We need to put MBOs back before we call most_stop_channel()
@@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, 
v4l2_std_id *norm)
        struct aim_fh *fh = priv;
        struct most_video_dev *mdev = fh->mdev;
 
-       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        *norm = V4L2_STD_UNKNOWN;
        return 0;
@@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void 
*priv, unsigned int index)
        struct aim_fh *fh = priv;
        struct most_video_dev *mdev = fh->mdev;
 
-       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index);
+       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
 
        if (index >= V4L2_AIM_MAX_INPUT)
                return -EINVAL;
@@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev 
*mdev)
 {
        int ret;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);


On Fri, 21 Apr 2017, Greg KH wrote:

> On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote:
> > 
> > Sorry about the top posting.
> > 
> > I did ask about it on the 9th of April and the reply was that the email
> > was 'acked'. Since I did not get a further email, I assumed it was lost.
> > Perhaps I misunderstood.
> 
> I really do not know, sorry.  If you didn't get an automated email from
> my system that it was applied, rebased it against the latest
> staging-next branch and resend it.
> 
> thanks,
> 
> greg k-h
> 

  reply	other threads:[~2017-04-25  6:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 19:49 Chandra Annamaneni
     [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
2017-04-10 11:21   ` Christian Gromm
2017-04-21  7:40   ` Chandra Annamaneni
2017-04-21  8:40     ` Greg KH
2017-04-21 18:06       ` Chandra Annamaneni
2017-04-21 18:19         ` Greg KH
2017-04-25  6:20           ` Chandra Annamaneni [this message]
2017-04-25 18:36             ` Greg KH
2017-04-26  2:28               ` Chandra Annamaneni
2017-04-26  2:55                 ` Joe Perches
2017-04-21 10:30     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1704242318590.23632@panther \
    --to=chandra627@gmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®