* Why does callback irq_startup in struct irq_chip return _unsigned_ int ?
@ 2017-05-25 21:28 Heiner Kallweit
2017-05-26 7:13 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2017-05-25 21:28 UTC (permalink / raw)
To: Thomas Gleixner, Linux Kernel Mailing List
Hi Thomas,
just by chance I noticed that callback irq_startup in struct irq_chip
returns an unsigned int.
This doesn't seem to make sense as the result is a normal retval which
is casted to a signed int in function irq_startup() anyway.
Is there any specific reason for this or is it simply a bug?
Rgds, Heiner
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Why does callback irq_startup in struct irq_chip return _unsigned_ int ?
2017-05-25 21:28 Why does callback irq_startup in struct irq_chip return _unsigned_ int ? Heiner Kallweit
@ 2017-05-26 7:13 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2017-05-26 7:13 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Linux Kernel Mailing List
Heiner,
On Thu, 25 May 2017, Heiner Kallweit wrote:
> just by chance I noticed that callback irq_startup in struct irq_chip
> returns an unsigned int.
> This doesn't seem to make sense as the result is a normal retval which
> is casted to a signed int in function irq_startup() anyway.
>
> Is there any specific reason for this or is it simply a bug?
/me scratches head.
IIRC then it was made unsigned int because that function cannot fail, but
can return that an interrupt was pending.
So if at all the thing should be 'bool'.
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-26 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 21:28 Why does callback irq_startup in struct irq_chip return _unsigned_ int ? Heiner Kallweit
2017-05-26 7:13 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®