mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Pavel Machek <pavel@ucw.cz>,
	Linus Walleij <linus.walleij@linaro.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [GIT pull] irq updates for 4.13
Date: Tue, 11 Jul 2017 17:07:01 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1707111654530.1799@nanos> (raw)
In-Reply-To: <alpine.DEB.2.20.1707111636180.1799@nanos>

On Tue, 11 Jul 2017, Thomas Gleixner wrote:
> On Tue, 11 Jul 2017, Tony Lindgren wrote:
> > * Thomas Gleixner <tglx@linutronix.de> [170711 02:48]:
> > And "external abort on non-linefetch" means something is not clocked
> > in this case. The following alone makes things boot for me again, but I don't
> > quite follow what has now changed with the ordering.. Thomas, any ideas?
> 
> Ah. Now that makes sense.
> 
> Unpatched the ordering is:
> 
> 	  chip_bus_lock(desc);
> 	  irq_request_resources(desc);
> 
> Now the offending change reordered the calls. OMAP gpio has:
> 
>     omap_gpio_irq_bus_lock()
>        pm_runtime_get_sync(bank->chip.parent);
> 
> So that at least explains the error. So that omap gpio irq chip (ab)uses
> the bus_lock() callback to do runtime power management. Sigh, I did not
> expect that. Let me have a deeper look if that's OMAP only or whether this
> happens in other places as well.

So OMAP-GPIO is the only driver which abuses bus_lock/unlock() in that way
and gets surprised.

Thanks,

	tglx

  reply	other threads:[~2017-07-11 15:07 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09  8:49 Thomas Gleixner
2017-07-10 13:35 ` Sebastian Reichel
2017-07-10 17:01   ` Linus Torvalds
2017-07-10 19:38     ` Pavel Machek
2017-07-10 20:15     ` Sebastian Reichel
2017-07-10 21:29       ` Linus Torvalds
2017-07-11  6:55     ` Thomas Gleixner
2017-07-11  9:26       ` Sebastian Reichel
2017-07-11  9:55         ` Thomas Gleixner
2017-07-11 10:52           ` Thomas Gleixner
2017-07-11 11:21             ` Sebastian Reichel
2017-07-11 13:27               ` Thomas Gleixner
2017-07-11 13:51               ` Marc Zyngier
2017-07-11 14:39                 ` Sebastian Reichel
2017-07-11  9:47       ` Thomas Gleixner
2017-07-11 13:51         ` Tony Lindgren
2017-07-11 14:41           ` Thomas Gleixner
2017-07-11 15:07             ` Thomas Gleixner [this message]
2017-07-11 15:43               ` Tony Lindgren
2017-07-11 15:39             ` Grygorii Strashko
2017-07-11 16:17               ` Tony Lindgren
2017-07-12  8:00               ` Geert Uytterhoeven
2017-07-11 15:40             ` Linus Torvalds
2017-07-11 16:14               ` Sebastian Reichel
2017-07-11 16:15               ` Tony Lindgren
2017-07-11 17:17                 ` Thomas Gleixner
2017-07-11 17:39                   ` Tony Lindgren
2017-07-11 16:19               ` Thomas Gleixner
2017-07-11 16:31                 ` Linus Torvalds
2017-07-11 17:52                   ` Thomas Gleixner
2017-07-11 18:16                     ` Linus Torvalds
2017-07-11 21:30                       ` Sebastian Reichel
2017-07-11 21:41                       ` Thomas Gleixner
2017-07-11 22:04                         ` Linus Torvalds
2017-07-11 22:51                         ` Sebastian Reichel
2017-07-12  5:29                           ` Tony Lindgren
2017-07-15 20:24                             ` Pavel Machek
2017-07-17  6:21                               ` Tony Lindgren
2017-07-17 20:01                               ` Linus Torvalds
2017-07-17 21:33                                 ` Pavel Machek
2017-07-11 16:34                 ` Tony Lindgren
2017-07-11 14:41           ` Sebastian Reichel
2017-07-11 16:20             ` Tony Lindgren
2017-07-11 16:34               ` Sebastian Reichel
  -- strict thread matches above, loose matches on Subject: below --
2017-07-03  7:42 Thomas Gleixner
2017-07-04  0:00 ` Linus Torvalds
2017-07-04  8:12   ` Thomas Gleixner
2017-07-04 10:29     ` Thomas Gleixner
2017-07-04 15:17   ` Jens Axboe
2017-07-04 18:34     ` Linus Torvalds
2017-07-04 19:10       ` Thomas Gleixner
2017-07-04 20:48         ` Max Gurtovoy
2017-07-06 13:58           ` Max Gurtovoy
2017-07-04 21:56       ` Jens Axboe
2017-07-05 15:14   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1707111654530.1799@nanos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=hpa@zytor.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sebastian.reichel@collabora.co.uk \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®