From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Jason Cooper <jason@lakedaemon.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers
Date: Wed, 26 Jul 2017 16:24:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707261620430.2186@nanos> (raw)
In-Reply-To: <218865f9-ac06-ba47-287e-cff188957736@arm.com>
On Wed, 26 Jul 2017, Marc Zyngier wrote:
> On 26/07/17 14:14, Masahiro Yamada wrote:
> > The irqchip maintainers applied drivers
> > with user-configurable Kconfig entries.
>
> They are *not* user-selectable, since there is *NO* menu entry. *You*
> are making them user-selectable, and I'm objecting to that.
Masahiro is right. They are user selectable.
Enable CONFIG_SOC_IMX51 and you'll get a prompt for
TS-4800 IRQ controller
in the middle of the 'Device Drivers' menu. Same for the other options,
which have prompts. The irqchip Kconfig is included from drivers/Kconfig so
there is menu context, just not a proper one.
I agree that this is crap and these prompts should be removed and the irq
thingy selected by the stuff which needs it.
Thanks,
tglx
next prev parent reply other threads:[~2017-07-26 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 4:03 Masahiro Yamada
2017-07-26 8:04 ` Marc Zyngier
2017-07-26 10:18 ` Masahiro Yamada
2017-07-26 10:37 ` Marc Zyngier
2017-07-26 13:14 ` Masahiro Yamada
2017-07-26 13:50 ` Marc Zyngier
2017-07-26 14:24 ` Thomas Gleixner [this message]
2017-07-26 14:48 ` Masahiro Yamada
2017-07-26 14:27 ` Masahiro Yamada
2017-07-26 14:58 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707261620430.2186@nanos \
--to=tglx@linutronix.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®