From: Thomas Gleixner <tglx@linutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq: remove redundant ->handle_irq assignment
Date: Mon, 14 Aug 2017 12:09:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708141206090.1865@nanos> (raw)
In-Reply-To: <1502329914-27098-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, 10 Aug 2017, Masahiro Yamada wrote:
> This function has "desc->handle_irq = handle;" a few lines above.
> The second assignment is redundant.
It's not as redundant as you might think. You missed to read the comment
above that. See also commit 1e12c4a9393b7.
Thanks,
tglx
prev parent reply other threads:[~2017-08-14 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 1:51 Masahiro Yamada
2017-08-14 10:09 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708141206090.1865@nanos \
--to=tglx@linutronix.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®