From: Thomas Gleixner <tglx@linutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework
Date: Mon, 14 Aug 2017 16:48:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708141647390.1865@nanos> (raw)
In-Reply-To: <CAMRc=Mdsc9W5VJStkhwiKyc4evEnw1j6D8D3FewmVvGaSV4keA@mail.gmail.com>
On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> 2017-08-14 15:06 GMT+02:00 Thomas Gleixner <tglx@linutronix.de>:
> > On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> >
> >> Implement a simple, irq_work-based framework for simulating
> >> interrupts. Currently the API exposes routines for initializing and
> >> deinitializing the simulator object, enqueueing the interrupts and
> >> retrieving the allocated interrupt numbers based on the offset of the
> >> dummy interrupt in the simulator struct.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >> ---
> >> include/linux/irq_sim.h | 44 ++++++++++++++++++
> >> init/Kconfig | 4 ++
> >> kernel/Makefile | 1 +
> >> kernel/irq_sim.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Please move this to kernel/irq/ ... and the config option to kernel/irq/Kconfig.
> >
> > Thanks,
> >
> > tglx
> >
> >
>
> How about moving irq_work.c there too?
We could, but irq_work is not really part of the interrupt subsystem, while
your interrupt simulator definitely is.
Thanks,
tglx
next prev parent reply other threads:[~2017-08-14 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 11:20 [PATCH v3 0/3] simulated interrupts Bartosz Golaszewski
2017-08-14 11:20 ` [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski
2017-08-14 13:06 ` Thomas Gleixner
2017-08-14 14:40 ` Bartosz Golaszewski
2017-08-14 14:48 ` Thomas Gleixner [this message]
2017-08-14 14:49 ` Bartosz Golaszewski
2017-08-14 11:20 ` [PATCH v3 2/3] irq/irq_sim: add a devres variant of irq_sim_init() Bartosz Golaszewski
2017-08-14 11:20 ` [PATCH v3 3/3] gpio: mockup: use irq_sim Bartosz Golaszewski
2017-08-20 22:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708141647390.1865@nanos \
--to=tglx@linutronix.de \
--cc=bamvor.zhangjian@linaro.org \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®