From: Julia Lawall <julia.lawall@lip6.fr>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe
Date: Wed, 4 Oct 2017 19:07:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710041907100.2815@hadrien> (raw)
In-Reply-To: <CAB3L5owT483S1ytafbS1CVLS06069CtiB7LFcmQCTSOFMH3Exg@mail.gmail.com>
On Wed, 4 Oct 2017, Srishti Sharma wrote:
> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
> >> Again, you have three patches on different files with the same subject
> >> line. You could add the file name eg rtw_ap: to the subject line to make
> >> them unique.
> >>
> >
> > And the subject needs to start with [PATCH v3] and then after the
> > Signed off by line put:
> Shouldn't it be only v2 as I haven't sent a v2 for this before.
It should be ok. There was a v1 that only did list_entry and where all
the patches had the same subject, but Greg already dropped that one.
julia
>
> Regards,
> Srishti
> >
> > ---
> > v2 and v3: Changes to the subjects and changelogs.
> >
> > regards,
> > dan carpenter
>
next prev parent reply other threads:[~2017-10-04 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 13:12 Srishti Sharma
2017-10-04 13:34 ` [Outreachy kernel] " Julia Lawall
2017-10-04 15:08 ` Dan Carpenter
2017-10-04 16:32 ` Srishti Sharma
2017-10-04 17:07 ` Julia Lawall [this message]
2017-10-04 17:11 ` Srishti Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710041907100.2815@hadrien \
--to=julia.lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=srishtishar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®