mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Allen Pais <allen.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
	sboyd@codeaurora.org
Subject: Re: [PATCH 1/1] time: clocksource: use setup_timer() helper.
Date: Thu, 19 Oct 2017 16:30:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1710191629330.1971@nanos> (raw)
In-Reply-To: <1505999618-15087-1-git-send-email-allen.lkml@gmail.com>

On Thu, 21 Sep 2017, Allen Pais wrote:

>     Use setup_timer function instead of initializing timer with the
>     function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
>  kernel/time/clocksource.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 03918a1..5b51d5b 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
>  {
>  	if (watchdog_running || !watchdog || list_empty(&watchdog_list))
>  		return;
> -	init_timer(&watchdog_timer);
> -	watchdog_timer.function = clocksource_watchdog;
> +	setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);

We changed this to use the timer_setup() function. Please resend.

Thanks,

	tglx

      reply	other threads:[~2017-10-19 14:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 13:13 Allen Pais
2017-10-19 14:30 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1710191629330.1971@nanos \
    --to=tglx@linutronix.de \
    --cc=allen.lkml@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®