From: Thomas Gleixner <tglx@linutronix.de>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
Piotr Luc <piotr.luc@intel.com>, Kan Liang <kan.liang@intel.com>,
Borislav Petkov <bp@suse.de>,
Stephane Eranian <eranian@google.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Mathias Krause <minipli@googlemail.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH 1/3 v4] perf/x86/intel/uncore: Cache logical pkg id in uncore driver
Date: Wed, 1 Nov 2017 17:30:31 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711011727080.1942@nanos> (raw)
In-Reply-To: <20171025120940.15721-2-prarit@redhat.com>
On Wed, 25 Oct 2017, Prarit Bhargava wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The SNB-EP uncore driver is the only user of topology_phys_to_logical_pkg
> in a performance critical path. Change it query the logical pkg ID
> only once at initialization time and then cache it in box structure.
That second sentence needs some care:
Avoid the lookup in the hotpath and cache the id at initialization
time. This is also a prerequisite to change the underlying logical
package management implementation w/o impacting this driver.
Other than that.
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2017-11-01 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 12:09 [PATCH 0/3 v4] Fix panic in logical packages calculation Prarit Bhargava
2017-10-25 12:09 ` [PATCH 1/3 v4] perf/x86/intel/uncore: Cache logical pkg id in uncore driver Prarit Bhargava
2017-11-01 16:30 ` Thomas Gleixner [this message]
2017-10-25 12:09 ` [PATCH 2/3 v4] x86/topology: Avoid wasting 128k for package id array Prarit Bhargava
2017-11-01 16:56 ` Thomas Gleixner
2017-11-03 14:53 ` Prarit Bhargava
2017-10-25 12:09 ` [PATCH 3/3 v4] x86/smpboot: Fix __max_logical_packages estimate Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711011727080.1942@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=kan.liang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=peterz@infradead.org \
--cc=piotr.luc@intel.com \
--cc=prarit@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®