From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
Robert Richter <rric@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/oprofile/ppro: Do not use __this_cpu* accessors in preemptible context
Date: Wed, 8 Nov 2017 11:48:28 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711081147310.1937@nanos> (raw)
In-Reply-To: <20171107175307.yl25jewyopgymil4@pd.tnic>
On Tue, 7 Nov 2017, Borislav Petkov wrote:
> --- a/arch/x86/oprofile/op_model_ppro.c
> +++ b/arch/x86/oprofile/op_model_ppro.c
> @@ -212,8 +212,9 @@ static void arch_perfmon_setup_counters(void)
> eax.full = cpuid_eax(0xa);
>
> /* Workaround for BIOS bugs in 6/15. Taken from perfmon2 */
> - if (eax.split.version_id == 0 && __this_cpu_read(cpu_info.x86) == 6 &&
> - __this_cpu_read(cpu_info.x86_model) == 15) {
> + if (eax.split.version_id == 0 &&
> + boot_cpu_data.x86 == 6 &&
> + boot_cpu_data.x86_model == 15) {
> eax.split.version_id = 2;
> eax.split.num_counters = 2;
> eax.split.bit_width = 40;
AFAICT, ppro_setup_ctrs() has the same issue
next prev parent reply other threads:[~2017-11-08 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 9:35 [oprofile_arch_init] BUG: using __this_cpu_read() in preemptible [00000000] code: swapper/0/1 Fengguang Wu
2017-11-07 16:43 ` Linus Torvalds
2017-11-07 17:53 ` [PATCH] x86/oprofile/ppro: Do not use __this_cpu* accessors in preemptible context Borislav Petkov
2017-11-08 6:53 ` Fengguang Wu
2017-11-08 10:48 ` Thomas Gleixner [this message]
2017-11-08 11:24 ` Borislav Petkov
2017-11-08 12:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711081147310.1937@nanos \
--to=tglx@linutronix.de \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®