mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
	Robert Richter <rric@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/oprofile/ppro: Do not use __this_cpu* accessors in preemptible context
Date: Wed, 8 Nov 2017 13:01:03 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1711081258540.1937@nanos> (raw)
In-Reply-To: <20171108112438.picwbvlobmzvaonr@pd.tnic>

On Wed, 8 Nov 2017, Borislav Petkov wrote:

> On Wed, Nov 08, 2017 at 11:48:28AM +0100, Thomas Gleixner wrote:
> > AFAICT, ppro_setup_ctrs() has the same issue
> 
> Here's an updated patch:

Sorry for misleading you. That function is actually correct as it is called
from the cpu online callback with interrupts disabled.

I'll drop that hunk again.

Thanks,

	tglx

      reply	other threads:[~2017-11-08 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  9:35 [oprofile_arch_init] BUG: using __this_cpu_read() in preemptible [00000000] code: swapper/0/1 Fengguang Wu
2017-11-07 16:43 ` Linus Torvalds
2017-11-07 17:53   ` [PATCH] x86/oprofile/ppro: Do not use __this_cpu* accessors in preemptible context Borislav Petkov
2017-11-08  6:53     ` Fengguang Wu
2017-11-08 10:48     ` Thomas Gleixner
2017-11-08 11:24       ` Borislav Petkov
2017-11-08 12:01         ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1711081258540.1937@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=fengguang.wu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oprofile-list@lists.sf.net \
    --cc=rric@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®