From: Thomas Gleixner <tglx@linutronix.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, y2038@lists.linaro.org
Subject: Re: [PATCH 4/9] posix-clocks: Enable compat syscalls always
Date: Mon, 13 Nov 2017 22:03:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711132159450.2097@nanos> (raw)
In-Reply-To: <20171110224259.15930-5-deepa.kernel@gmail.com>
On Fri, 10 Nov 2017, Deepa Dinamani wrote:
>
> -#ifdef CONFIG_COMPAT
> -
> COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
> struct compat_timespec __user *, rmtp)
> {
> @@ -1574,7 +1572,6 @@ COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
> current->restart_block.nanosleep.compat_rmtp = rmtp;
> return hrtimer_nanosleep(&tu, HRTIMER_MODE_REL, CLOCK_MONOTONIC);
> }
> -#endif
So if I'm not missing something important this will make the compat syscall
define available even for
CONFIG_X86_64=y
CONFIG_IA32_EMULATION=n
CONFIG_X86_X32=n
which is wrong because in that configuration we don't have any 32bit
executable support. So why would we need a compat syscall in that case?
Thanks,
tglx
next prev parent reply other threads:[~2017-11-13 21:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 22:42 [PATCH 0/9] posix_clocks: Prepare syscalls for 64 bit time_t conversion Deepa Dinamani
2017-11-10 22:42 ` [PATCH 1/9] include: Move compat_timespec/ timeval to compat_time.h Deepa Dinamani
2017-11-11 2:38 ` Steven Rostedt
2017-11-10 22:42 ` [PATCH 2/9] compat: Make compat helpers independent of CONFIG_COMPAT Deepa Dinamani
2017-11-14 16:47 ` Arnd Bergmann
2017-11-15 23:01 ` Deepa Dinamani
2017-11-10 22:42 ` [PATCH 3/9] compat: enable compat_get/put_timespec64 always Deepa Dinamani
2017-11-10 22:42 ` [PATCH 4/9] posix-clocks: Enable compat syscalls always Deepa Dinamani
2017-11-13 21:03 ` Thomas Gleixner [this message]
2017-11-13 23:26 ` Deepa Dinamani
2017-11-14 13:03 ` Arnd Bergmann
2017-11-10 22:42 ` [PATCH 5/9] y2038: introduce CONFIG_64BIT_TIME Deepa Dinamani
2017-12-08 16:53 ` [Y2038] " Ben Hutchings
2017-12-08 17:01 ` Deepa Dinamani
2017-12-08 18:23 ` Ben Hutchings
2017-11-10 22:42 ` [PATCH 6/9] include: Add new y2038 safe __kernel_timespec Deepa Dinamani
2017-11-10 22:42 ` [PATCH 7/9] fix get_timespec64() for y2038 safe compat interfaces Deepa Dinamani
2017-11-14 14:17 ` Arnd Bergmann
2017-11-10 22:42 ` [PATCH 8/9] change time types to new y2038 safe __kernel_* types Deepa Dinamani
2017-11-10 22:42 ` [PATCH 9/9] nanosleep: change time types to " Deepa Dinamani
2017-11-14 14:24 ` [PATCH 0/9] posix_clocks: Prepare syscalls for 64 bit time_t conversion Arnd Bergmann
2017-11-15 23:11 ` Deepa Dinamani
2017-11-16 9:04 ` Thomas Gleixner
2017-11-16 23:42 ` Arnd Bergmann
2017-11-17 8:58 ` Thomas Gleixner
2017-11-17 9:31 ` Arnd Bergmann
2017-11-17 9:54 ` Thomas Gleixner
2017-11-17 10:30 ` Arnd Bergmann
2017-11-17 10:40 ` Thomas Gleixner
2017-11-17 10:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711132159450.2097@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®