From: Julia Lawall <julia.lawall@lip6.fr>
To: Joe Perches <joe@perches.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
cocci@systeme.lip6.fr
Subject: Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency
Date: Thu, 16 Nov 2017 08:31:24 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711160830190.12570@hadrien> (raw)
In-Reply-To: <1510783347.25299.2.camel@perches.com>
On Wed, 15 Nov 2017, Joe Perches wrote:
> On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote:
> > What version of Coccinelle do you have?
> > > I tried 1.0.4 and 1.0.6,
> > > but both failed.
> > For me, it also fails for 1.0.6. It should be OK for 1.0.7.
>
> Then likely this patch should not be applied or
> some form of local version checking should be done
> in the script itself.
>
> Scripts that use various tools are subject to
> language versioning requirements.
>
> For instance, there are many things that are
> possible with later versions of perl, but are not
> done for various scripts because many distributions
> do not ship with the latest versions.
It will say coccicheck failed if it is not compatible with the version of
Coccinelle. But it shouldn't break anything. We should put that it
requires 1.0.7, but I don't know if that is actually checked, or just
provided as documentation for the reader.
julia
prev parent reply other threads:[~2017-11-16 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 16:08 Julia Lawall
2017-11-15 14:46 ` Masahiro Yamada
2017-11-15 14:51 ` Julia Lawall
2017-11-15 15:26 ` Masahiro Yamada
2017-11-15 15:29 ` Julia Lawall
2017-11-15 21:55 ` Julia Lawall
2017-11-15 22:02 ` Joe Perches
2017-11-16 0:02 ` Masahiro Yamada
2017-11-16 7:31 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711160830190.12570@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®