mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>, Borislav Petkov <bpetkov@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Brian Gerst <brgerst@gmail.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH 1/2] Undo the split of setup_cpu_entry_area
Date: Sat, 2 Dec 2017 11:47:15 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712021146320.2199@nanos> (raw)
In-Reply-To: <alpine.DEB.2.20.1712021131210.2199@nanos>

On Sat, 2 Dec 2017, Thomas Gleixner wrote:

> On Fri, 1 Dec 2017, Andy Lutomirski wrote:
> 
> > This is obviously a hack.  Either the patch should be adjusted back to
> > the version I sent or trap_init should forcibly initialize all PMDs
> > by something like __set_fixmap(..., __mkpte(0)); or however it's spelled.
> 
> I split it because the whole thing crashed when I kept the loop you had
> because it tried to allocate stuff. Had no time to figure out why, so I
> went the lazy way of making it "work".

[    0.000000]  dump_stack+0x85/0xc5
[    0.000000]  warn_alloc+0x114/0x1c0
[    0.000000]  __alloc_pages_slowpath+0x1089/0x10d0
[    0.000000]  __alloc_pages_nodemask+0x2e8/0x370
[    0.000000]  __get_free_pages+0x10/0x40
[    0.000000]  kpti_shadow_pagetable_walk+0x2b2/0x3e0
[    0.000000]  kpti_add_user_map+0xfe/0x330
[    0.000000]  kpti_add_mapping_cpu_entry+0x5a/0x100
[    0.000000]  trap_init+0x2c/0x7b
[    0.000000]  start_kernel+0x24c/0x497
[    0.000000]  secondary_startup_64+0xa5/0xb0

Cute, isn't it? And then further down the line it triplefaults of course. 

  reply	other threads:[~2017-12-02 10:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02  6:20 [PATCH 0/2] KPTI: get rid of cpu_entry_area mapping duplication Andy Lutomirski
2017-12-02  6:20 ` [PATCH 1/2] Undo the split of setup_cpu_entry_area Andy Lutomirski
2017-12-02 10:34   ` Thomas Gleixner
2017-12-02 10:47     ` Thomas Gleixner [this message]
2017-12-02 13:34       ` Andy Lutomirski
2017-12-02 14:20         ` Thomas Gleixner
2017-12-02  6:20 ` [PATCH 2/2] x86/kpti: Reference all cpu_entry_area pagetables in the usermode tables Andy Lutomirski
2017-12-02 10:38   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712021146320.2199@nanos \
    --to=tglx@linutronix.de \
    --cc=bpetkov@suse.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@intel.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®