From: Andy Lutomirski <luto@kernel.org>
To: X86 ML <x86@kernel.org>
Cc: Borislav Petkov <bpetkov@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 1/2] Undo the split of setup_cpu_entry_area
Date: Fri, 1 Dec 2017 22:20:10 -0800 [thread overview]
Message-ID: <de55fb2a2fe1a8d3826e50223bb08430682f0e4b.1512195450.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1512195450.git.luto@kernel.org>
In-Reply-To: <cover.1512195450.git.luto@kernel.org>
This is obviously a hack. Either the patch should be adjusted back to
the version I sent or trap_init should forcibly initialize all PMDs
by something like __set_fixmap(..., __mkpte(0)); or however it's spelled.
---
arch/x86/kernel/smpboot.c | 2 ++
arch/x86/kernel/traps.c | 6 +++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 26317716559d..1325844b930a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1232,8 +1232,10 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
* The boot CPU area has been set up in trap_init()
* already.
*/
+ /*
if (i)
setup_cpu_entry_area(i);
+ */
}
/*
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index ff4e6b595ae4..0ad92f35a75b 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -945,8 +945,12 @@ dotraplinkage void do_iret_error(struct pt_regs *regs, long error_code)
void __init trap_init(void)
{
+ int cpu;
/* Init cpu_entry_area before IST entries are set up */
- setup_cpu_entry_area(smp_processor_id());
+ for_each_possible_cpu(cpu) {
+ pr_err("setup_cpu_entry_area(%d)\n", cpu);
+ setup_cpu_entry_area(cpu);
+ }
idt_setup_traps();
--
2.13.6
next prev parent reply other threads:[~2017-12-02 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 6:20 [PATCH 0/2] KPTI: get rid of cpu_entry_area mapping duplication Andy Lutomirski
2017-12-02 6:20 ` Andy Lutomirski [this message]
2017-12-02 10:34 ` [PATCH 1/2] Undo the split of setup_cpu_entry_area Thomas Gleixner
2017-12-02 10:47 ` Thomas Gleixner
2017-12-02 13:34 ` Andy Lutomirski
2017-12-02 14:20 ` Thomas Gleixner
2017-12-02 6:20 ` [PATCH 2/2] x86/kpti: Reference all cpu_entry_area pagetables in the usermode tables Andy Lutomirski
2017-12-02 10:38 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de55fb2a2fe1a8d3826e50223bb08430682f0e4b.1512195450.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=bpetkov@suse.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@intel.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®