From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, "Tobin C. Harding" <me@tobin.cc>,
x86@kernel.org
Subject: Re: [PATCH] Do not hash userspace addresses in fault handlers
Date: Thu, 21 Dec 2017 11:27:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1712211127280.1741@nanos> (raw)
In-Reply-To: <20171219215223.GA21997@beast>
On Tue, 19 Dec 2017, Kees Cook wrote:
> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index febf6980e653..06fe3d51d385 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -860,7 +860,7 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code,
> if (!printk_ratelimit())
> return;
>
> - printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx",
> + printk("%s%s[%d]: segfault at %lx ip %px sp %px error %lx",
> task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
> tsk->comm, task_pid_nr(tsk), address,
> (void *)regs->ip, (void *)regs->sp, error_code);
For that part:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
prev parent reply other threads:[~2017-12-21 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 21:52 Kees Cook
2017-12-21 10:27 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712211127280.1741@nanos \
--to=tglx@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®