* [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing
@ 2017-12-29 18:14 Jérémy Lefaure
2017-12-29 18:22 ` Julia Lawall
2018-01-01 9:19 ` Masahiro Yamada
0 siblings, 2 replies; 4+ messages in thread
From: Jérémy Lefaure @ 2017-12-29 18:14 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Masahiro Yamada,
Michal Marek
Cc: cocci, linux-kernel, Jérémy Lefaure
Rule r does not depend on rule i (which is the include of
linux/kernel.h) so the output should not depend on i in
org and report mode.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
scripts/coccinelle/misc/array_size.cocci | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
index 6ec05710b017..09520f0941f0 100644
--- a/scripts/coccinelle/misc/array_size.cocci
+++ b/scripts/coccinelle/misc/array_size.cocci
@@ -72,13 +72,13 @@ position p;
(sizeof(E)@p /sizeof(T))
)
-@script:python depends on i&&org@
+@script:python depends on org@
p << r.p;
@@
coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
-@script:python depends on i&&report@
+@script:python depends on report@
p << r.p;
@@
--
2.14.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing
2017-12-29 18:14 [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing Jérémy Lefaure
@ 2017-12-29 18:22 ` Julia Lawall
2018-01-01 9:19 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-12-29 18:22 UTC (permalink / raw)
To: Jérémy Lefaure
Cc: Gilles Muller, Nicolas Palix, Masahiro Yamada, Michal Marek,
cocci, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Fri, 29 Dec 2017, Jérémy Lefaure wrote:
> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Re-Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> scripts/coccinelle/misc/array_size.cocci | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> index 6ec05710b017..09520f0941f0 100644
> --- a/scripts/coccinelle/misc/array_size.cocci
> +++ b/scripts/coccinelle/misc/array_size.cocci
> @@ -72,13 +72,13 @@ position p;
> (sizeof(E)@p /sizeof(T))
> )
>
> -@script:python depends on i&&org@
> +@script:python depends on org@
> p << r.p;
> @@
>
> coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
>
> -@script:python depends on i&&report@
> +@script:python depends on report@
> p << r.p;
> @@
>
> --
> 2.14.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing
2017-12-29 18:14 [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing Jérémy Lefaure
2017-12-29 18:22 ` Julia Lawall
@ 2018-01-01 9:19 ` Masahiro Yamada
2018-01-01 9:36 ` Julia Lawall
1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-01-01 9:19 UTC (permalink / raw)
To: Jérémy Lefaure
Cc: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek, cocci,
Linux Kernel Mailing List
2017-12-30 3:14 GMT+09:00 Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>:
> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
Applied to linux-kbuild/misc. Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing
2018-01-01 9:19 ` Masahiro Yamada
@ 2018-01-01 9:36 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2018-01-01 9:36 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Jérémy Lefaure, Gilles Muller, Nicolas Palix,
Michal Marek, cocci, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Mon, 1 Jan 2018, Masahiro Yamada wrote:
> 2017-12-30 3:14 GMT+09:00 Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>:
> > Rule r does not depend on rule i (which is the include of
> > linux/kernel.h) so the output should not depend on i in
> > org and report mode.
> >
> > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
>
>
> Applied to linux-kbuild/misc. Thanks!
Thanks, and happy new year!
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-01 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-29 18:14 [RESEND PATCH 1/1] Coccinelle: array_size: report even if include is missing Jérémy Lefaure
2017-12-29 18:22 ` Julia Lawall
2018-01-01 9:19 ` Masahiro Yamada
2018-01-01 9:36 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®