From: Julia Lawall <julia.lawall@lip6.fr>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, kbuild-all@01.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings
Date: Mon, 15 Jan 2018 14:58:25 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801151457080.3305@hadrien> (raw)
In-Reply-To: <20180115135102.GA5519@ulmo>
On Mon, 15 Jan 2018, Thierry Reding wrote:
> On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote:
> > From: Fengguang Wu <fengguang.wu@intel.com>
> >
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> > drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >
> > tree: https://github.com/thierryreding/linux for-4.16/work
> > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4
> > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP
> >
> > nouveau_gem.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Hi Julia,
>
> thanks for the patch. However, the tree that you generated it against is
> a personal development tree and it happens to have a bunch of commits in
> it that are very experimental and some of which are very unlikely to go
> upstream. There's an IOCTL addition patch (touched by hunk 7 in this
> patch) that is used only for testing purposes. All of the other hunks do
> pply properly to linux-next, so I think those can be posted. Nouveau is
> maintained by Ben Skeggs, though, so they should be addressed to him.
>
> I don't personally mind getting these patches, and I don't mind people
> seeing the personal development tree (it's publicly available, after
> all) but I think patches against this tree will be confusing to anyone
> but me because they are likely not going to apply anywhere other than
> that tree.
OK, I'm just forwarding what kbuild sends me for approval. No problem if
you toss it, apply it, or do whatever seems reasonable :)
julia
>
> Thanks,
> Thierry
>
prev parent reply other threads:[~2018-01-15 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 12:47 Julia Lawall
2018-01-15 13:51 ` [Nouveau] " Thierry Reding
2018-01-15 13:58 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801151457080.3305@hadrien \
--to=julia.lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®