From: Thomas Gleixner <tglx@linutronix.de>
To: Kan Liang <kan.liang@intel.com>
Cc: mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, acme@kernel.org,
eranian@google.com, ak@linux.intel.com
Subject: Re: [PATCH V5 1/8] perf/x86/intel/uncore: customized event_read for client IMC uncore
Date: Thu, 18 Jan 2018 10:36:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801181036210.1847@nanos> (raw)
In-Reply-To: <1516042629-387021-1-git-send-email-kan.liang@intel.com>
On Mon, 15 Jan 2018, kan.liang@intel.com wrote:
> From: Kan Liang <Kan.liang@intel.com>
>
> There are two free running counters for client IMC uncore. The custom
> event_init() function hardcode their index to 'UNCORE_PMC_IDX_FIXED' and
> 'UNCORE_PMC_IDX_FIXED + 1'. To support the 'UNCORE_PMC_IDX_FIXED + 1'
> case, the generic uncore_perf_event_update is obscurely hacked.
> The code quality issue will bring problem when new counter index is
> introduced into generic code. For example, free running counter index.
>
> Introduce customized event_read function for client IMC uncore.
> The customized function is exactly copied from previous generic
> uncore_pmu_event_read.
> The 'UNCORE_PMC_IDX_FIXED + 1' case will be isolated for client IMC
> uncore only.
>
> Signed-off-by: Kan Liang <Kan.liang@intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
prev parent reply other threads:[~2018-01-18 9:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 18:57 kan.liang
2018-01-15 18:57 ` [PATCH V5 2/8] perf/x86/intel/uncore: correct fixed counter index check for NHM kan.liang
2018-01-15 18:57 ` [PATCH V5 3/8] perf/x86/intel/uncore: correct fixed counter index check in generic code kan.liang
2018-01-15 18:57 ` [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures for free running counters kan.liang
2018-01-18 13:32 ` Peter Zijlstra
2018-01-18 17:43 ` Liang, Kan
2018-01-19 13:07 ` Peter Zijlstra
2018-01-19 15:15 ` Liang, Kan
2018-01-19 17:19 ` Peter Zijlstra
2018-01-19 17:34 ` Stephane Eranian
2018-01-19 17:53 ` Liang, Kan
2018-01-19 17:55 ` Stephane Eranian
2018-01-19 18:00 ` Liang, Kan
2018-01-19 20:18 ` Stephane Eranian
2018-01-19 20:24 ` Andi Kleen
2018-01-19 20:50 ` Stephane Eranian
2018-01-19 20:51 ` Stephane Eranian
2018-01-20 1:24 ` Andi Kleen
2018-01-19 21:33 ` Peter Zijlstra
2018-01-23 22:00 ` Liang, Kan
2018-01-24 10:17 ` Peter Zijlstra
2018-01-24 15:46 ` Liang, Kan
2018-01-15 18:57 ` [PATCH V5 5/8] perf/x86/intel/uncore: add infrastructure for free running counter kan.liang
2018-01-15 18:57 ` [PATCH V5 6/8] perf/x86/intel/uncore: SKX support for IIO free running counters kan.liang
2018-01-15 18:57 ` [PATCH V5 7/8] perf/x86/intel/uncore: expose uncore_pmu_event functions kan.liang
2018-01-15 18:57 ` [PATCH V5 8/8] perf/x86/intel/uncore: clean up client IMC uncore kan.liang
2018-01-18 9:36 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801181036210.1847@nanos \
--to=tglx@linutronix.de \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®