From: Thomas Gleixner <tglx@linutronix.de>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: linux@armlinux.org.uk, catalin.marinas@arm.com,
Will Deacon <will.deacon@arm.com>,
jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
shorne@gmail.com, Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
patches@groups.riscv.org
Subject: Re: [PATCH v2 1/4] arm: Make set_handle_irq and handle_arch_irq generic
Date: Thu, 25 Jan 2018 10:05:57 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801250959070.2020@nanos> (raw)
In-Reply-To: <20180125030756.21787-2-palmer@sifive.com>
On Wed, 24 Jan 2018, Palmer Dabbelt wrote:
> It looks like this same irqchip registration mechanism has been copied
> into a handful of ports, including aarch64 and openrisc. I want to use
> this in the RISC-V port, so I thought it would be good to make this
> generic instead.
>
> This patch simply moves set_handle_irq and handle_arch_irq from arch/arm
> to kernel/irq/handle.c.
>
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
> ---
> arch/arm/Kconfig | 5 -----
> arch/arm/include/asm/irq.h | 5 -----
> arch/arm/kernel/entry-armv.S | 6 ------
> arch/arm/kernel/irq.c | 10 ----------
> include/linux/irq.h | 18 ++++++++++++++++++
> kernel/irq/Kconfig | 5 +++++
> kernel/irq/handle.c | 10 ++++++++++
Please split the patches into two pieces:
1) Add the infrastructure to the generic code and have a new Kconfig symbol
GENERIC_IRQ_MULTI_HANDLER
or something which fits in the GENERIC_IRQ_ name space.
That also makes sure that the build does not fail after patch 1 for the
non converted arch. With your change this breaks arm64 build with only
patch 1 applied because the Kconfig symbol is defined twice and the code
is defined twice. See drivers/irqchip/Kconfig ARM_GIC_V3 ....
2) Convert both arm and arm64 over along with the select statements in the
arch and irqchip Kconfigs
Thanks,
tglx
next prev parent reply other threads:[~2018-01-25 9:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 3:07 Palmer Dabbelt
2018-01-25 3:07 ` [PATCH v2 1/4] arm: " Palmer Dabbelt
2018-01-25 7:45 ` Christoph Hellwig
2018-01-25 9:05 ` Thomas Gleixner [this message]
2018-01-25 3:07 ` [PATCH v2 2/4] arm64: Use the new MULTI_IRQ_HANDLER Palmer Dabbelt
2018-01-25 7:45 ` Christoph Hellwig
2018-01-25 3:07 ` [PATCH v2 3/4] openrisc: " Palmer Dabbelt
2018-01-25 7:46 ` Christoph Hellwig
2018-01-27 3:13 ` Stafford Horne
2018-01-25 3:07 ` [PATCH v2 4/4] RISC-V: Move to the new generic IRQ handler Palmer Dabbelt
2018-01-25 7:46 ` Christoph Hellwig
2018-01-25 8:31 ` Stafford Horne
2018-01-25 16:04 ` [patches] " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801250959070.2020@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=palmer@sifive.com \
--cc=patches@groups.riscv.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®