From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Jim Mattson" <jmattson@google.com>,
"Mihai Carabas" <mihai.carabas@oracle.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"kvm list" <kvm@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Liran Alon" <liran.alon@oracle.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Borislav Petkov" <bp@alien8.de>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Subject: Re: [9/8] KVM: x86: limit MSR_IA32_SPEC_CTRL access based on CPUID availability
Date: Tue, 30 Jan 2018 18:45:19 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801301842310.1797@nanos> (raw)
In-Reply-To: <1517332457.18619.132.camel@infradead.org>
On Tue, 30 Jan 2018, David Woodhouse wrote:
> On Tue, 2018-01-30 at 08:57 -0800, Jim Mattson wrote:
> > It's really hard to tell which patches are being proposed for which
> > repositories, but assuming that everything else is correct, I don't
> > think your condition is adequate. What if the physical CPU and the
> > virtual CPU both have CPUID.(EAX=7H,ECX=0):EDX[26], but only the
> > physical CPU has CPUID.(EAX=7H,ECX=0):EDX[27]? If the guest has write
> > access to MSR_IA32_SPEC_CTRL, it can set MSR_IA32_SPEC_CTRL[1]
> > (STIBP), even though setting that bit in the guest should raise #GP.
>
> Everything we're talking about here is for tip/x86/pti. Which I note
> has just updated to be 4.15-based, although I thought it was going to
> stay on 4.14 for now. So I've updated my tree at
> http://git.infradead.org/linux-retpoline.git/shortlog/refs/heads/ibpb
> accordingly.
Yes, we tried to stay on 4.14 base but this started to created nasty merge
conflicts for no value. Merging in v4.15 turned out to resolve those issues
while still serving as the feed branch for Gregs stable work. For the time
being we try to make stable backporting at least for 4.14/15 as painless as
possible.
Thanks,
tglx
next prev parent reply other threads:[~2018-01-30 17:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 12:03 [PATCH v2 0/8] KVM: x86: expose CVE-2017-5715 ("Spectre variant 2") mitigations to guest Paolo Bonzini
2018-01-09 12:03 ` [PATCH 1/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT accessors Paolo Bonzini
2018-01-15 9:42 ` David Hildenbrand
2018-01-09 12:03 ` [PATCH 2/8] x86/msr: add definitions for indirect branch predictor MSRs Paolo Bonzini
2018-01-09 12:03 ` [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest Paolo Bonzini
2018-01-13 10:16 ` Longpeng (Mike)
2018-01-15 9:23 ` Paolo Bonzini
2018-01-15 9:34 ` Thomas Gleixner
2018-01-09 12:03 ` [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU Paolo Bonzini
2018-01-12 1:49 ` Wanpeng Li
2018-01-12 17:03 ` Jim Mattson
2018-01-13 9:29 ` Woodhouse, David
2018-01-15 9:21 ` Paolo Bonzini
2018-01-09 12:03 ` [PATCH 5/8] KVM: SVM: fix comment Paolo Bonzini
2018-01-15 9:53 ` David Hildenbrand
2018-01-09 12:03 ` [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest Paolo Bonzini
2018-01-09 14:22 ` Konrad Rzeszutek Wilk
2018-01-09 16:05 ` Paolo Bonzini
2018-01-09 16:08 ` Paolo Bonzini
2018-01-11 10:45 ` Wanpeng Li
2018-01-10 20:13 ` Tom Lendacky
2018-01-11 10:33 ` Paolo Bonzini
2018-01-09 12:03 ` [PATCH 7/8] x86/svm: Set IBPB when running a different VCPU Paolo Bonzini
2018-01-09 14:23 ` Konrad Rzeszutek Wilk
2018-01-09 12:03 ` [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists Paolo Bonzini
2018-01-13 1:25 ` Eric Wheeler
2018-01-13 8:00 ` Paolo Bonzini
2018-01-16 0:40 ` Eric Wheeler
2018-01-16 7:39 ` R: " Paolo Bonzini
2018-01-09 12:03 ` [PATCH 9/8] KVM: x86: limit MSR_IA32_SPEC_CTRL access based on CPUID availability Paolo Bonzini
2018-01-16 0:55 ` Eric Wheeler
2018-01-16 12:59 ` Paolo Bonzini
2018-01-30 13:21 ` [9/8] " Mihai Carabas
2018-01-30 16:33 ` Jim Mattson
2018-01-30 16:43 ` Mihai Carabas
2018-01-30 16:57 ` Jim Mattson
2018-01-30 17:14 ` David Woodhouse
2018-01-30 17:38 ` Jim Mattson
2018-01-30 17:45 ` Thomas Gleixner [this message]
2018-01-30 23:11 ` Paolo Bonzini
2018-01-30 23:47 ` David Woodhouse
2018-01-31 1:06 ` Paolo Bonzini
2018-02-05 11:10 ` Ingo Molnar
2018-02-05 11:15 ` David Woodhouse
2018-02-05 12:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801301842310.1797@nanos \
--to=tglx@linutronix.de \
--cc=aliguori@amazon.com \
--cc=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=jmattson@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®