From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Longpeng (Mike)" <longpeng2@huawei.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
rkrcmar@redhat.com, liran.alon@oracle.com, jmattson@google.com,
aliguori@amazon.com, thomas.lendacky@amd.com, dwmw@amazon.co.uk,
bp@alien8.de, x86@kernel.org, Gonglei <arei.gonglei@huawei.com>
Subject: Re: [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest
Date: Mon, 15 Jan 2018 10:34:59 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1801151033140.1810@nanos> (raw)
In-Reply-To: <93f6b277-fd12-71a0-3334-f92e069a9615@redhat.com>
On Mon, 15 Jan 2018, Paolo Bonzini wrote:
> On 13/01/2018 11:16, Longpeng (Mike) wrote:
> >> + /*
> >> + * FIXME: this is only needed until SPEC_CTRL is supported
> >> + * by upstream Linux in cpufeatures, then it can be replaced
> >> + * with static_cpu_has.
> >> + */
> >> + have_spec_ctrl = cpu_has_spec_ctrl();
> >> + if (have_spec_ctrl)
> >> + pr_info("kvm: SPEC_CTRL available\n");
> >> + else
> >> + pr_info("kvm: SPEC_CTRL not available\n");
> >> +
> >
> > In this approach, we must reload these modules if we update the microcode later ?
>
> I strongly suggest using early microcode update anyway.
We had the discussion already and we are not going to support late micro
code loading. It's just not worth the trouble.
Also please do not commit any of this before we have sorted out the bare
metal IBRS/IBPB support. We really don't want to have two variants of that
in tree.
Thanks,
tglx
next prev parent reply other threads:[~2018-01-15 9:35 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 12:03 [PATCH v2 0/8] KVM: x86: expose CVE-2017-5715 ("Spectre variant 2") mitigations to guest Paolo Bonzini
2018-01-09 12:03 ` [PATCH 1/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT accessors Paolo Bonzini
2018-01-15 9:42 ` David Hildenbrand
2018-01-09 12:03 ` [PATCH 2/8] x86/msr: add definitions for indirect branch predictor MSRs Paolo Bonzini
2018-01-09 12:03 ` [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest Paolo Bonzini
2018-01-13 10:16 ` Longpeng (Mike)
2018-01-15 9:23 ` Paolo Bonzini
2018-01-15 9:34 ` Thomas Gleixner [this message]
2018-01-09 12:03 ` [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU Paolo Bonzini
2018-01-12 1:49 ` Wanpeng Li
2018-01-12 17:03 ` Jim Mattson
2018-01-13 9:29 ` Woodhouse, David
2018-01-15 9:21 ` Paolo Bonzini
2018-01-09 12:03 ` [PATCH 5/8] KVM: SVM: fix comment Paolo Bonzini
2018-01-15 9:53 ` David Hildenbrand
2018-01-09 12:03 ` [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest Paolo Bonzini
2018-01-09 14:22 ` Konrad Rzeszutek Wilk
2018-01-09 16:05 ` Paolo Bonzini
2018-01-09 16:08 ` Paolo Bonzini
2018-01-11 10:45 ` Wanpeng Li
2018-01-10 20:13 ` Tom Lendacky
2018-01-11 10:33 ` Paolo Bonzini
2018-01-09 12:03 ` [PATCH 7/8] x86/svm: Set IBPB when running a different VCPU Paolo Bonzini
2018-01-09 14:23 ` Konrad Rzeszutek Wilk
2018-01-09 12:03 ` [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists Paolo Bonzini
2018-01-13 1:25 ` Eric Wheeler
2018-01-13 8:00 ` Paolo Bonzini
2018-01-16 0:40 ` Eric Wheeler
2018-01-16 7:39 ` R: " Paolo Bonzini
2018-01-09 12:03 ` [PATCH 9/8] KVM: x86: limit MSR_IA32_SPEC_CTRL access based on CPUID availability Paolo Bonzini
2018-01-16 0:55 ` Eric Wheeler
2018-01-16 12:59 ` Paolo Bonzini
2018-01-30 13:21 ` [9/8] " Mihai Carabas
2018-01-30 16:33 ` Jim Mattson
2018-01-30 16:43 ` Mihai Carabas
2018-01-30 16:57 ` Jim Mattson
2018-01-30 17:14 ` David Woodhouse
2018-01-30 17:38 ` Jim Mattson
2018-01-30 17:45 ` Thomas Gleixner
2018-01-30 23:11 ` Paolo Bonzini
2018-01-30 23:47 ` David Woodhouse
2018-01-31 1:06 ` Paolo Bonzini
2018-02-05 11:10 ` Ingo Molnar
2018-02-05 11:15 ` David Woodhouse
2018-02-05 12:10 ` Ingo Molnar
2018-01-09 16:06 [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest Liran Alon
2018-01-09 16:48 Liran Alon
2018-01-09 16:57 ` Paolo Bonzini
2018-01-10 5:03 ` Nadav Amit
2018-01-10 13:20 ` Paolo Bonzini
2018-01-10 14:06 ` Arjan van de Ven
2018-01-10 14:28 ` Paolo Bonzini
2018-01-10 15:41 ` Konrad Rzeszutek Wilk
2018-01-10 15:45 ` Paolo Bonzini
2018-01-10 15:48 ` Woodhouse, David
2018-01-10 15:56 ` Paolo Bonzini
2018-01-10 16:05 ` David Woodhouse
2018-01-12 23:17 ` Jim Mattson
2018-01-12 23:19 ` Nadav Amit
2018-01-10 0:33 Liran Alon
2018-01-10 16:19 Liran Alon
2018-01-10 16:27 ` Paolo Bonzini
2018-01-10 17:14 ` Jim Mattson
2018-01-10 17:16 ` Paolo Bonzini
2018-01-10 17:23 ` Nadav Amit
2018-01-10 17:32 ` Jim Mattson
2018-01-10 16:47 ` David Woodhouse
2018-01-10 16:51 Liran Alon
2018-01-10 17:07 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801151033140.1810@nanos \
--to=tglx@linutronix.de \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=bp@alien8.de \
--cc=dwmw@amazon.co.uk \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=longpeng2@huawei.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®