* [PATCH] drm: fix semicolon.cocci warnings
@ 2018-04-12 5:52 Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2018-04-12 5:52 UTC (permalink / raw)
To: Joel Stanley
Cc: David Airlie, Andrew Jeffery, linux-aspeed, linux-kernel, kbuild-all
From: Fengguang Wu <fengguang.wu@intel.com>
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
aspeed_gfx_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -203,7 +203,7 @@ static irqreturn_t aspeed_gfx_irq_handle
drm_crtc_handle_vblank(&priv->pipe.crtc);
writel(reg, priv->base + CRT_CTRL1);
return IRQ_HANDLED;
- };
+ }
return IRQ_NONE;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
@ 2021-05-11 16:11 kernel test robot
2021-05-11 16:11 ` [PATCH] drm: fix semicolon.cocci warnings kernel test robot
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-05-11 16:11 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: kbuild-all, linux-kernel, Daniel Vetter
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1140ab592e2ebf8153d2b322604031a8868ce7a5
commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
date: 6 months ago
config: i386-randconfig-c021-20210511 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41796 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm: fix semicolon.cocci warnings
2021-05-11 16:11 drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon kernel test robot
@ 2021-05-11 16:11 ` kernel test robot
2021-05-11 17:17 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-05-11 16:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: kbuild-all, linux-kernel, Daniel Vetter, Anitha Chrisanthus,
Edmund Dea, David Airlie, dri-devel
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
CC: Geert Uytterhoeven <geert+renesas@glider.be>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1140ab592e2ebf8153d2b322604031a8868ce7a5
commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
:::::: branch date: 18 hours ago
:::::: commit date: 6 months ago
kmb_dsi.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/gpu/drm/kmb/kmb_dsi.c
+++ b/drivers/gpu/drm/kmb/kmb_dsi.c
@@ -281,7 +281,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_YCBCR422_16B:
data_type_param.size_constraint_pixels = 2;
@@ -301,7 +301,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_LPPS_YCBCR422_20B:
case DSI_LP_DT_PPS_YCBCR422_24B:
@@ -318,7 +318,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_RGB565_16B:
data_type_param.size_constraint_pixels = 1;
@@ -337,7 +337,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
return -EINVAL;
- };
+ }
break;
case DSI_LP_DT_PPS_RGB666_18B:
data_type_param.size_constraint_pixels = 4;
@@ -361,7 +361,7 @@ static u32 mipi_get_datatype_params(u32
default:
DRM_ERROR("DSI: Invalid data_type %d\n", data_type);
return -EINVAL;
- };
+ }
*params = data_type_param;
return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: fix semicolon.cocci warnings
2021-05-11 16:11 ` [PATCH] drm: fix semicolon.cocci warnings kernel test robot
@ 2021-05-11 17:17 ` Daniel Vetter
2021-05-11 18:27 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2021-05-11 17:17 UTC (permalink / raw)
To: kernel test robot
Cc: Geert Uytterhoeven, kbuild-all, linux-kernel, Daniel Vetter,
Anitha Chrisanthus, Edmund Dea, David Airlie, dri-devel
On Wed, May 12, 2021 at 12:11:23AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
> drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
> CC: Geert Uytterhoeven <geert+renesas@glider.be>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Applied to drm-misc-next for 5.14, thanks for the patch.
-Daniel
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 1140ab592e2ebf8153d2b322604031a8868ce7a5
> commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
> :::::: branch date: 18 hours ago
> :::::: commit date: 6 months ago
>
> kmb_dsi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> --- a/drivers/gpu/drm/kmb/kmb_dsi.c
> +++ b/drivers/gpu/drm/kmb/kmb_dsi.c
> @@ -281,7 +281,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_YCBCR422_16B:
> data_type_param.size_constraint_pixels = 2;
> @@ -301,7 +301,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_LPPS_YCBCR422_20B:
> case DSI_LP_DT_PPS_YCBCR422_24B:
> @@ -318,7 +318,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_RGB565_16B:
> data_type_param.size_constraint_pixels = 1;
> @@ -337,7 +337,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_mode %d\n", data_mode);
> return -EINVAL;
> - };
> + }
> break;
> case DSI_LP_DT_PPS_RGB666_18B:
> data_type_param.size_constraint_pixels = 4;
> @@ -361,7 +361,7 @@ static u32 mipi_get_datatype_params(u32
> default:
> DRM_ERROR("DSI: Invalid data_type %d\n", data_type);
> return -EINVAL;
> - };
> + }
>
> *params = data_type_param;
> return 0;
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: fix semicolon.cocci warnings
2021-05-11 17:17 ` Daniel Vetter
@ 2021-05-11 18:27 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-05-11 18:27 UTC (permalink / raw)
To: kernel test robot, Daniel Vetter
Cc: kbuild-all, Linux Kernel Mailing List, Anitha Chrisanthus,
Edmund Dea, David Airlie, DRI Development
On Tue, May 11, 2021 at 7:17 PM Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, May 12, 2021 at 12:11:23AM +0800, kernel test robot wrote:
> > From: kernel test robot <lkp@intel.com>
> >
> > drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon
> > drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unneeded semicolon
> >
> >
> > Remove unneeded semicolon.
> >
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> >
> > Fixes: ade896460e4a ("drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY")
This Fixed-tag is completely bogus. The right one is
Fixes: 98521f4d4b4cb265 ("drm/kmb: Mipi DSI part of the display driver")
> > CC: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 5:52 [PATCH] drm: fix semicolon.cocci warnings Julia Lawall
2021-05-11 16:11 drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon kernel test robot
2021-05-11 16:11 ` [PATCH] drm: fix semicolon.cocci warnings kernel test robot
2021-05-11 17:17 ` Daniel Vetter
2021-05-11 18:27 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®