mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <dou_liyang@163.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com,
	hpa@zytor.com, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH v2 1/2] irq/matrix: Split out the CPU finding code into a helper
Date: Sat, 8 Sep 2018 11:59:19 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1809081155280.1402@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180908070037.31154-1-dou_liyang@163.com>

On Sat, 8 Sep 2018, Dou Liyang wrote:
> +/* Find the best CPU which has the lowest vector allocation count */
> +static int matrix_find_best_cpu(struct irq_matrix *m,
> +				const struct cpumask *msk, int *best_cpu)
> +{
> +	unsigned int cpu, maxavl = 0;
> +	struct cpumap *cm;
> +
> +	for_each_cpu(cpu, msk) {
> +		cm = per_cpu_ptr(m->maps, cpu);
> +
> +		if (!cm->online || cm->available <= maxavl)
> +			continue;
> +
> +		*best_cpu = cpu;
> +		maxavl = cm->available;
> +	}
> +
> +	return maxavl;

This return value makes no sense whatsoever. Why not doing the obvious

static unsigned int matrix_find_best_cpu(struct irq_matrix *m,
	                             	 const struct cpumask *msk)
{
	unsigned int cpu, best_cpu, maxavl = 0;

	best_cpu = UINT_MAX;
	.....
	return best_cpu;
}

and at the call site:

       cpu = matrix_find_best_cpu();
       if (cpu == UINT_MAX)
       		return -ENOSPC;

Hmm?

> +	cm = per_cpu_ptr(m->maps, best_cpu);
> +	bit = matrix_alloc_area(m, cm, 1, false);
> +	if (bit < m->alloc_end) {

So if you're removing one indentation level, then it'd be consequent to
remove this one as well while at it :)

Thanks,

	tglx

      parent reply	other threads:[~2018-09-08  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08  7:00 Dou Liyang
2018-09-08  7:00 ` [PATCH v2 2/2] irq/matrix: Spread managed interrupts on allocation Dou Liyang
2018-09-08 10:20   ` Thomas Gleixner
2018-09-08  9:59 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1809081155280.1402@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=dou_liyang@163.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®