mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <dou_liyang@163.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com,
	hpa@zytor.com, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH v2 2/2] irq/matrix: Spread managed interrupts on allocation
Date: Sat, 8 Sep 2018 12:20:33 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1809081159240.1402@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180908070037.31154-2-dou_liyang@163.com>

On Sat, 8 Sep 2018, Dou Liyang wrote:
> Spread managed interrupt on allocation as well.
> 
> Fixes: a0c9259dc4e1("irq/matrix: Spread interrupts on allocation")

No. This is an enhancement and not a fix.

> -	cpumask_and(vector_searchmask, vector_searchmask, affmsk);
> -	cpu = cpumask_first(vector_searchmask);
> -	if (cpu >= nr_cpu_ids)
> -		return -EINVAL;

Removing this check changes the return value for the empty search mask case
from EINVAL to ENOSPC. Doesn't matter much I think, but it might be worth
to mention in the changelog.

Thanks,

	tglx

  reply	other threads:[~2018-09-08 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08  7:00 [PATCH v2 1/2] irq/matrix: Split out the CPU finding code into a helper Dou Liyang
2018-09-08  7:00 ` [PATCH v2 2/2] irq/matrix: Spread managed interrupts on allocation Dou Liyang
2018-09-08 10:20   ` Thomas Gleixner [this message]
2018-09-08  9:59 ` [PATCH v2 1/2] irq/matrix: Split out the CPU finding code into a helper Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1809081159240.1402@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=dou_liyang@163.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®