From: Thomas Gleixner <tglx@linutronix.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Mathieu Malaterre <malat@debian.org>,
od@zcrc.me, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org,
linux-doc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v11 04/27] clocksource: Add a new timer-ingenic driver
Date: Fri, 5 Apr 2019 22:44:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1904052241240.1802@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190327231631.15708-5-paul@crapouillou.net>
On Thu, 28 Mar 2019, Paul Cercueil wrote:
> This driver handles the TCU (Timer Counter Unit) present on the Ingenic
> JZ47xx SoCs, and provides the kernel with a system timer, and optionally
> with a clocksource and a sched_clock.
>
> It also provides clocks and interrupt handling to client drivers.
Why on earth has a timer driver clock and interrupt chip drivers in it?
We have different subsystems for good reasons. Please split this apart and
add the support to the appropriate subsystems, clocksource, irqchip, clk
Thanks,
tglx
next prev parent reply other threads:[~2019-04-05 20:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 23:16 [PATCH v11 00/27] Ingenic JZ47xx TCU pachset v11 Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 01/27] dt-bindings: ingenic: Add DT bindings for TCU clocks Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 02/27] doc: Add doc for the Ingenic TCU hardware Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 03/27] dt-bindings: Add doc for the Ingenic TCU drivers Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 04/27] clocksource: Add a new timer-ingenic driver Paul Cercueil
2019-04-05 20:44 ` Thomas Gleixner [this message]
2019-03-27 23:16 ` [PATCH v11 05/27] clocksource: Add driver for the Ingenic JZ47xx OST Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 06/27] MAINTAINERS: Add myself as maintainer for Ingenic TCU drivers Paul Cercueil
2019-03-28 1:29 ` Joe Perches
2019-03-27 23:16 ` [PATCH v11 07/27] watchdog: jz4740: Use WDT clock provided by TCU driver Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 08/27] watchdog: jz4740: Use regmap " Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 09/27] watchdog: jz4740: Avoid starting watchdog in set_timeout Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 10/27] watchdog: jz4740: Drop dependency on MACH_JZ47xx, use COMPILE_TEST Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 11/27] pwm: jz4740: Apply configuration atomically Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 12/27] pwm: jz4740: Use regmap from TCU driver Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 13/27] pwm: jz4740: Use clocks " Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 14/27] pwm: jz4740: Improve algorithm of clock calculation Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 15/27] pwm: jz4740: Allow selection of PWM channels 0 and 1 Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 16/27] pwm: jz4740: Drop dependency on MACH_INGENIC, use COMPILE_TEST Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 17/27] pwm: jz4740: Remove unused devicetree compatible strings Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 18/27] clk: jz4740: Add TCU clock Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 19/27] MIPS: Kconfig: Select TCU timer driver when MACH_INGENIC is set Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 20/27] MIPS: jz4740: Add DTS nodes for the TCU drivers Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 21/27] MIPS: qi_lb60: Move PWM devices to devicetree Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 22/27] MIPS: qi_lb60: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 23/27] MIPS: CI20: Reduce system timer and clocksource to 3 MHz Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 24/27] MIPS: CI20: defconfig: enable OST driver Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 25/27] MIPS: GCW0: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 26/27] MIPS: GCW0: defconfig: Enable OST, watchdog, PWM drivers Paul Cercueil
2019-03-27 23:16 ` [PATCH v11 27/27] MIPS: jz4740: Drop obsolete code Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904052241240.1802@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhogan@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®