mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ben Greear <greearb@candelatech.com>,
	stable@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Jiri Kosina <jikos@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	David Woodhouse <dwmw@amazon.co.uk>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jon Masters <jcm@redhat.com>, Waiman Long <longman9394@gmail.com>,
	Borislav Petkov <bp@alien8.de>,
	Mark Gross <mgross@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org
Subject: Re: [PATCH v3] Documentation: Add section about CPU vulnerabilities for Spectre
Date: Mon, 17 Jun 2019 22:21:51 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1906172217540.1963@nanos.tec.linutronix.de> (raw)
In-Reply-To: <c63945d34bfc9df2412f813d0b9b3a321a65de5d.1560795378.git.tim.c.chen@linux.intel.com>

Tim,

On Mon, 17 Jun 2019, Tim Chen wrote:

> +Spectre variant 1 attacks take advantage of speculative execution of
> +conditional branches, while Spectre variant 2 attacks use speculative
> +execution of indirect branches to leak privileged memory. See [1] [5]
> +[7] [10] [11].

It would be great to actually link these [N] to the actual http link at the
bottom. No idea what's the best way to do that.

Jonathan?

> +Mitigation control on the kernel command line
> +---------------------------------------------
> +
> +Spectre variant 2 mitigation can be disabled or force enabled at the
> +kernel command line.

The below renders horribly when converted to HTML

You probably want to wrap these into a table

> +	nospectre_v2	[X86] Disable all mitigations for the Spectre variant 2
> +			(indirect branch prediction) vulnerability. System may
> +			allow data leaks with this option, which is equivalent
> +			to spectre_v2=off.
> +
> +
> +        spectre_v2=     [X86] Control mitigation of Spectre variant 2
> +			(indirect branch speculation) vulnerability.
> +			The default operation protects the kernel from
> +			user space attacks.

Maybe Jonathan has a better idea.

Other than those formatting detail, this looks really good. Well done!

Thanks,

	tglx

  reply	other threads:[~2019-06-17 20:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 19:11 Tim Chen
2019-06-17 20:21 ` Thomas Gleixner [this message]
2019-06-17 20:23   ` Thomas Gleixner
2019-06-17 22:16   ` Jonathan Corbet
2019-06-17 23:22     ` Tim Chen
2019-06-17 20:22 ` Jon Masters
2019-06-17 20:30   ` Jon Masters
2019-06-18 20:05     ` Tim Chen
2019-06-18 20:33       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1906172217540.1963@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=asit.k.mallick@intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=greearb@candelatech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcm@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman9394@gmail.com \
    --cc=mgross@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®