From: Paul Walmsley <paul.walmsley@sifive.com>
To: Greentime Hu <greentime.hu@sifive.com>
Cc: green.hu@gmail.com, greentime@kernel.org, palmer@dabbelt.com,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
schwab@suse.de, anup@brainfault.org
Subject: Re: [PATCH v3] riscv: make sure the cores stay looping in .Lsecondary_park
Date: Sun, 12 Jan 2020 10:12:21 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.2001121011100.160130@viisi.sifive.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.2001091126480.135239@viisi.sifive.com>
Hi Greentime,
On Thu, 9 Jan 2020, Paul Walmsley wrote:
> On Thu, 9 Jan 2020, Greentime Hu wrote:
>
> > The code in secondary_park is currently placed in the .init section. The
> > kernel reclaims and clears this code when it finishes booting. That
> > causes the cores parked in it to go to somewhere unpredictable, so we
> > move this function out of init to make sure the cores stay looping there.
> >
> > Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> > Reviewed-by: Anup Patel <anup@brainfault.org>
>
> Thanks, the following is what's been queued for v5.5-rc.
During final testing, when building the kernel with an initramfs, I hit
the following linker error:
LD .tmp_vmlinux1
arch/riscv/kernel/head.o: in function `.L0 ':(.init.text+0x5c): relocation truncated to fit: R_RISCV_JAL against `.Lsecondary_park'
make[1]: *** [Makefile:1079: vmlinux] Error 1
make: *** [Makefile:326: __build_one_by_one] Error 2
Could you take a look at this?
thanks,
- Paul
next prev parent reply other threads:[~2020-01-12 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 3:15 Greentime Hu
2020-01-09 19:27 ` Paul Walmsley
2020-01-12 18:12 ` Paul Walmsley [this message]
2020-01-14 3:48 ` Greentime Hu
2020-01-14 22:55 ` Paul Walmsley
2020-01-15 7:06 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.2001121011100.160130@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=anup@brainfault.org \
--cc=green.hu@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=greentime@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®