From: Paul Walmsley <paul.walmsley@sifive.com>
To: Greentime Hu <greentime.hu@sifive.com>
Cc: Gt <green.hu@gmail.com>,
greentime@kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andreas Schwab <schwab@suse.de>, Anup Patel <anup@brainfault.org>
Subject: Re: [PATCH v3] riscv: make sure the cores stay looping in .Lsecondary_park
Date: Tue, 14 Jan 2020 14:55:12 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.2001141449500.21279@viisi.sifive.com> (raw)
In-Reply-To: <CAHCEehKchrwd7TTmSrhtEPeCmkrYrx7TX_c6ogpCpSkCKnBQoQ@mail.gmail.com>
Hi Greentime,
On Tue, 14 Jan 2020, Greentime Hu wrote:
> I think it is because the sections are too far for bqeu to jump and
> the config I used just small enough for it to jump so I didn't see
> this bug. Sorry about that.
No problem.
> I tried this fix to boot in Unleashed board.
>
> #ifdef CONFIG_SMP
> li t0, CONFIG_NR_CPUS
> - bgeu a0, t0, .Lsecondary_park
> + blt a0, t0, .Lgood_cores
> + tail .Lsecondary_park
> +.Lgood_cores:
> #endif
Looks reasonable to me. Care to update and repost the patch?
- Paul
next prev parent reply other threads:[~2020-01-14 22:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 3:15 Greentime Hu
2020-01-09 19:27 ` Paul Walmsley
2020-01-12 18:12 ` Paul Walmsley
2020-01-14 3:48 ` Greentime Hu
2020-01-14 22:55 ` Paul Walmsley [this message]
2020-01-15 7:06 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.2001141449500.21279@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=anup@brainfault.org \
--cc=green.hu@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=greentime@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®