From: "Kenneth R. Crudup" <kenny@panix.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: Commit 25f12ae45fc1 ("maccess: rename probe_kernel_address to get_kernel_nofault") causing several OOPSes
Date: Sat, 20 Jun 2020 06:46:27 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2006200640370.2845@xps-7390> (raw)
In-Reply-To: <20200619074233.GA3723@lst.de>
> > Thing is, there's other examples of the previous version in the kernel tree- any
> > chance there's a usage conflict (Thunderbolt has a ROM in it, maybe something in
> > "probe_roms.c"? (Just guessing, no idea):
On Fri, 19 Jun 2020, Christoph Hellwig wrote:
> Maybe. But nothing looks strange there. Just to re-reconfirm, you had to
> revert "maccess: rename probe_kernel_address to get_kernel_nofault",
> "maccess: make get_kernel_nofault() check for minimal type compatibility"
> wasn't enough?
Yeah, the only commit I had to revert was this one. BUT:
> Below is a patch to do a "partial revert" for probe_roms.c. I'd be
> totally surprised if it changes anything from staring at it for while,
> but anyway..
So, be totally surprised :) I've just booted with "maccess: rename
probe_kernel_address to get_kernel_nofault" intact and your probe_roms.c
patch with no issues.
(Perhaps there's some sort of compiler optimization going on?)
-Kenny
--
Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Orange County CA
next prev parent reply other threads:[~2020-06-20 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.22.394.2006181751270.9276@xps-7390>
2020-06-19 6:50 ` Christoph Hellwig
2020-06-19 6:57 ` Kenneth R. Crudup
2020-06-19 7:42 ` Christoph Hellwig
2020-06-19 7:45 ` Kenneth R. Crudup
2020-06-20 13:46 ` Kenneth R. Crudup [this message]
2020-06-20 16:49 ` Linus Torvalds
2020-06-20 17:50 ` Linus Torvalds
2020-06-21 19:33 ` Kenneth R. Crudup
2020-06-21 19:29 ` Kenneth R. Crudup
2020-06-21 19:44 ` Linus Torvalds
2020-06-26 8:36 ` Kenneth R. Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2006200640370.2845@xps-7390 \
--to=kenny@panix.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®