From: Julia Lawall <julia.lawall@inria.fr>
To: Chen Yu <yu.chen.surf@gmail.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sched/fair: check for idle core
Date: Fri, 23 Oct 2020 18:52:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010231850320.2707@hadrien> (raw)
In-Reply-To: <CADjb_WSG-z78KYmS=f2cLYdYLeqi=eqmLw+Q=sMGOBEM7Bw2Ug@mail.gmail.com>
On Sat, 24 Oct 2020, Chen Yu wrote:
> On Fri, Oct 23, 2020 at 1:32 AM Julia Lawall <Julia.Lawall@inria.fr> wrote:
> >
> [cut]
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index aa4c6227cd6d..9b23dad883ee 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -5804,6 +5804,9 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync)
> > if (sync && cpu_rq(this_cpu)->nr_running == 1)
> > return this_cpu;
> >
> > + if (available_idle_cpu(prev_cpu))
> How about also taking sched_idle_cpu(prev_cpu) into consideration?
> if (available_idle_cpu(prev_cpu) || sched_idle_cpu(prev_cpu))
I have no opinion about this, because it wasn't relevant to the
application I was looking at. The available_idle check on prev previously
in wake_affine_idle doesn't check sched_idle_cpu, so I didn't put it here.
julia
next prev parent reply other threads:[~2020-10-23 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 13:15 Julia Lawall
2020-10-23 8:40 ` Mel Gorman
2020-10-23 9:21 ` Julia Lawall
2020-10-23 10:05 ` Mel Gorman
2020-10-23 16:28 ` Chen Yu
2020-10-23 16:52 ` Julia Lawall [this message]
2020-10-27 9:19 ` Mel Gorman
2020-10-27 10:00 ` Julia Lawall
2021-01-24 20:38 ` Julia Lawall
2021-01-25 9:12 ` Mel Gorman
2021-01-25 9:20 ` Julia Lawall
2021-01-25 9:25 ` Vincent Guittot
2021-01-25 13:38 ` Julia Lawall
2021-02-06 17:20 ` Julia Lawall
2020-10-29 10:51 ` [tip: sched/core] sched/fair: Check for idle core in wake_affine tip-bot2 for Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010231850320.2707@hadrien \
--to=julia.lawall@inria.fr \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®