From: Julia Lawall <julia.lawall@inria.fr>
To: Mel Gorman <mgorman@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched/fair: check for idle core
Date: Tue, 27 Oct 2020 11:00:23 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010271100110.2847@hadrien> (raw)
In-Reply-To: <20201027091936.GS32041@suse.de>
On Tue, 27 Oct 2020, Mel Gorman wrote:
> On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote:
> > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in wakeup path")
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> > Reviewed-by Vincent Guittot <vincent.guittot@linaro.org>
> >
>
> While not a universal win, it was mostly a win or neutral. In few cases
> where there was a problem, one benchmark I'm a bit suspicious of generally
> as occasionally it generates bad results for unknown and unpredictable
> reasons. In another, it was very machine specific and the differences
> were small in absolte time rather than relative time. Other tests on the
> same machine were fine so overall;
Thanks for testing!
julia
>
> Acked-by: Mel Gorman <mgorman@suse.de>
>
> Thanks.
>
> --
> Mel Gorman
> SUSE Labs
>
next prev parent reply other threads:[~2020-10-27 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 13:15 Julia Lawall
2020-10-23 8:40 ` Mel Gorman
2020-10-23 9:21 ` Julia Lawall
2020-10-23 10:05 ` Mel Gorman
2020-10-23 16:28 ` Chen Yu
2020-10-23 16:52 ` Julia Lawall
2020-10-27 9:19 ` Mel Gorman
2020-10-27 10:00 ` Julia Lawall [this message]
2021-01-24 20:38 ` Julia Lawall
2021-01-25 9:12 ` Mel Gorman
2021-01-25 9:20 ` Julia Lawall
2021-01-25 9:25 ` Vincent Guittot
2021-01-25 13:38 ` Julia Lawall
2021-02-06 17:20 ` Julia Lawall
2020-10-29 10:51 ` [tip: sched/core] sched/fair: Check for idle core in wake_affine tip-bot2 for Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010271100110.2847@hadrien \
--to=julia.lawall@inria.fr \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®