From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Sumera Priyadarsini <sylphrenadin@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] Coccinelle: Checking the relevance of parentheses in “git grep”
Date: Tue, 27 Oct 2020 11:55:53 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010271155330.2847@hadrien> (raw)
In-Reply-To: <45310257-201a-40ea-348f-b8e909c3775c@web.de>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Tue, 27 Oct 2020, Markus Elfring wrote:
> > Will any adjustments become relevant then accordingly?
>
> I have found out that the function “interpret” (OCaml code) constructs a command
> and executes it.
> https://github.com/coccinelle/coccinelle/blob/3c01dc1696dc5ccfb319673f205e491b572ee0be/parsing_cocci/git_grep.ml#L9
>
> I have tried a corresponding test display out. Thus I have got the impression
> that desired patterns are passed with extra parentheses.
>
> … git grep -l -w \( -e for_each_node_by_type … -e for_each_node_with_property \) -- '*.c'
>
>
> How do you think about to omit these parentheses here?
Does it make a difference?
julia
next prev parent reply other threads:[~2020-10-27 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <78f8b08754dde286adf7e11e1eeb3bb8ad500d8b.camel@web.de>
[not found] ` <acaed49b9195d47e252a0b67551f87e96324d004.camel@web.de>
2020-10-22 12:35 ` Coccinelle: Checking the influence of “Grep query” Julia Lawall
[not found] ` <6fe4c63d-1b7e-b947-139c-423edc519d2f@web.de>
2020-10-28 6:50 ` Julia Lawall
[not found] ` <45310257-201a-40ea-348f-b8e909c3775c@web.de>
2020-10-27 10:55 ` Julia Lawall [this message]
[not found] ` <bfb3e786-a64f-ecaf-eb37-8bd6b53cf38a@web.de>
2020-10-27 12:03 ` [Cocci] Coccinelle: Checking the relevance of parentheses in “git grep” Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010271155330.2847@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®