From: Julia Lawall <julia.lawall@inria.fr>
To: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
marcocesati@gmail.com, fabioaiuto83@gmail.com,
dan.carpenter@oracle.com, phil@philpotter.co.uk,
amarjargal16@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8723bs: core: remove empty comment
Date: Wed, 31 Mar 2021 22:12:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2103312212200.3008@hadrien> (raw)
In-Reply-To: <f6be2f84ff5b29a51ca6be0d269c50d54568b2e2.1617221075.git.deborahbrouwer3563@gmail.com>
On Wed, 31 Mar 2021, Deborah Brouwer wrote:
> Remove empty comment instead of fixing the checkpatch warning that it was
> generating.
Maybe it woudl be better to focus on the purpose of what you are doing.
Something like:
Remove empty comment, which provides no information.
julia
>
> Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 428c71ce0334..7b4c0f22cd90 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -876,8 +876,6 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr
> *(payload+curfragnum), *(payload+curfragnum+1), *(payload+curfragnum+2), *(payload+curfragnum+3),
> *(payload+curfragnum+4), *(payload+curfragnum+5), *(payload+curfragnum+6), *(payload+curfragnum+7)));
> }
> -/*
> -*/
> }
> return _SUCCESS;
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/f6be2f84ff5b29a51ca6be0d269c50d54568b2e2.1617221075.git.deborahbrouwer3563%40gmail.com.
>
next prev parent reply other threads:[~2021-03-31 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 20:05 [PATCH 0/3] Fix block comment warnings Deborah Brouwer
2021-03-31 20:05 ` [PATCH 1/3] staging: rtl8723bs: core: fix repeated word warning Deborah Brouwer
2021-03-31 20:17 ` [Outreachy kernel] " Julia Lawall
2021-03-31 20:05 ` [PATCH 2/3] staging: rtl8723bs: core: fix block comment warning Deborah Brouwer
2021-03-31 20:15 ` [Outreachy kernel] " Julia Lawall
2021-03-31 20:05 ` [PATCH 3/3] staging: rtl8723bs: core: remove empty comment Deborah Brouwer
2021-03-31 20:12 ` Julia Lawall [this message]
2021-04-01 5:58 ` [PATCH 0/3] Fix block comment warnings Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2103312212200.3008@hadrien \
--to=julia.lawall@inria.fr \
--cc=amarjargal16@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=deborahbrouwer3563@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=phil@philpotter.co.uk \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®