From: Julia Lawall <julia.lawall@inria.fr>
To: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
marcocesati@gmail.com, fabioaiuto83@gmail.com,
dan.carpenter@oracle.com, phil@philpotter.co.uk,
amarjargal16@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8723bs: core: fix repeated word warning
Date: Wed, 31 Mar 2021 22:17:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2103312215430.3008@hadrien> (raw)
In-Reply-To: <14c1a1f1f0a34fb821d47ddab6e7e63800ec2736.1617221075.git.deborahbrouwer3563@gmail.com>
On Wed, 31 Mar 2021, Deborah Brouwer wrote:
> Fix checkpatch warning:
> WARNING: Possible repeated word: 'very'
This is a simple but clear example of how "Fix" doesn't help one
understand the patch. In reading the log message, one would probably
assume that you removed the repetition, but actually you added a comma.
So it would be better to explain what you did and why. It's good to
acknowledge checkpatch, but the text of the warning message is not that
useful.
julia
>
> Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 2daf5c461a4d..3878caf0b56c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -1700,7 +1700,7 @@ Calling context:
> If we turn on USE_RXTHREAD, then, no need for critical section.
> Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
>
> -Must be very very cautious...
> +Must be very, very cautious...
>
> */
> struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv)/* _queue *pfree_xmit_queue) */
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/14c1a1f1f0a34fb821d47ddab6e7e63800ec2736.1617221075.git.deborahbrouwer3563%40gmail.com.
>
next prev parent reply other threads:[~2021-03-31 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 20:05 [PATCH 0/3] Fix block comment warnings Deborah Brouwer
2021-03-31 20:05 ` [PATCH 1/3] staging: rtl8723bs: core: fix repeated word warning Deborah Brouwer
2021-03-31 20:17 ` Julia Lawall [this message]
2021-03-31 20:05 ` [PATCH 2/3] staging: rtl8723bs: core: fix block comment warning Deborah Brouwer
2021-03-31 20:15 ` [Outreachy kernel] " Julia Lawall
2021-03-31 20:05 ` [PATCH 3/3] staging: rtl8723bs: core: remove empty comment Deborah Brouwer
2021-03-31 20:12 ` [Outreachy kernel] " Julia Lawall
2021-04-01 5:58 ` [PATCH 0/3] Fix block comment warnings Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2103312215430.3008@hadrien \
--to=julia.lawall@inria.fr \
--cc=amarjargal16@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=deborahbrouwer3563@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=phil@philpotter.co.uk \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®