* [PATCH] coccinelle: adjust the confidence of uninitialized_var.cocci
@ 2021-12-14 12:19 Qing Wang
2021-12-26 10:45 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-12-14 12:19 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek, cocci,
linux-kernel
Cc: Wang Qing
From: Wang Qing <wangqing@vivo.com>
Since uninitialized_var() was removed, this cocci should reset its
confidence to low.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
scripts/coccinelle/misc/uninitialized_var.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/misc/uninitialized_var.cocci b/scripts/coccinelle/misc/uninitialized_var.cocci
index 69bbaae..79e02e3
--- a/scripts/coccinelle/misc/uninitialized_var.cocci
+++ b/scripts/coccinelle/misc/uninitialized_var.cocci
@@ -18,7 +18,7 @@
/// this kind were cleaned-up from the kernel. This cocci rule checks that
/// the macro is not explicitly or implicitly reintroduced.
///
-// Confidence: High
+// Confidence: Low
// Copyright: (C) 2020 Denis Efremov ISPRAS
// Options: --no-includes --include-headers
//
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] coccinelle: adjust the confidence of uninitialized_var.cocci
2021-12-14 12:19 [PATCH] coccinelle: adjust the confidence of uninitialized_var.cocci Qing Wang
@ 2021-12-26 10:45 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2021-12-26 10:45 UTC (permalink / raw)
To: Qing Wang; +Cc: Gilles Muller, Nicolas Palix, Michal Marek, cocci, linux-kernel
On Tue, 14 Dec 2021, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> Since uninitialized_var() was removed, this cocci should reset its
> confidence to low.
I'm not sure to understand the argument for this one. The semantic patch
in its current state is looking for declarations that hide an
uninitialized variable. The part about the uninitialized_var macro is not
there any more. The problem that is searched for seems reasonable to
address.
julia
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> scripts/coccinelle/misc/uninitialized_var.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/uninitialized_var.cocci b/scripts/coccinelle/misc/uninitialized_var.cocci
> index 69bbaae..79e02e3
> --- a/scripts/coccinelle/misc/uninitialized_var.cocci
> +++ b/scripts/coccinelle/misc/uninitialized_var.cocci
> @@ -18,7 +18,7 @@
> /// this kind were cleaned-up from the kernel. This cocci rule checks that
> /// the macro is not explicitly or implicitly reintroduced.
> ///
> -// Confidence: High
> +// Confidence: Low
> // Copyright: (C) 2020 Denis Efremov ISPRAS
> // Options: --no-includes --include-headers
> //
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-26 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 12:19 [PATCH] coccinelle: adjust the confidence of uninitialized_var.cocci Qing Wang
2021-12-26 10:45 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®