From: Linus Torvalds <torvalds@linux-foundation.org>
To: art@usfltd.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: git-tree compilation error "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!
Date: Sat, 5 May 2007 13:33:14 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0705051328100.3819@woody.linux-foundation.org> (raw)
In-Reply-To: <20070505092558.joq9kbhn284sc00c@67.106.77.56>
On Sat, 5 May 2007, art@usfltd.com wrote:
>
> WARNING: "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!
Ok, that driver needs to be converted to use "pci_register_driver()"
instead of "pci_module_init()". It's probably the following one-liner, do
you actually have that hardware to test?
Linus
---
drivers/scsi/tmscsim.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
printk (KERN_INFO "DC390: Using safe settings.\n");
}
- return pci_module_init(&dc390_driver);
+ return pci_register_driver(&dc390_driver);
}
static void __exit dc390_module_exit(void)
prev parent reply other threads:[~2007-05-05 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 14:25 art
2007-05-05 20:33 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0705051328100.3819@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=art@usfltd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®