git-tree compilation error "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!

git-tree compilation error "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!

[art]

pull 20070505 0830 UTC-06
...
scripts/kconfig/gconf arch/x86_64/Kconfig
drivers/net/Kconfig:2279:warning: 'select' used by config symbol  
'UCC_GETH' refer to undefined symbol 'UCC_FAST'
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config  
symbol 'KEYBOARD_ATARI' refer to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:161:warning: 'select' used by config  
symbol 'MOUSE_ATARI' refer to undefined symbol 'ATARI_KBD_CORE'
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   CHK     include/linux/compile.h
   MODPOST vmlinux
   Building modules, stage 2.
Kernel: arch/x86_64/boot/bzImage is ready  (#113)
   MODPOST 1234 modules
WARNING: "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2


xboom

art@usfltd.com

Re: git-tree compilation error "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!

[Linus Torvalds]

On Sat, 5 May 2007, art@usfltd.com wrote:
>
> WARNING: "pci_module_init" [drivers/scsi/tmscsim.ko] undefined!

Ok, that driver needs to be converted to use "pci_register_driver()" 
instead of "pci_module_init()". It's probably the following one-liner, do 
you actually have that hardware to test?

		Linus
---
 drivers/scsi/tmscsim.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
 		printk (KERN_INFO "DC390: Using safe settings.\n");
 	}
 
-	return pci_module_init(&dc390_driver);
+	return pci_register_driver(&dc390_driver);
 }
 
 static void __exit dc390_module_exit(void)