From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Ulrich Drepper <drepper@redhat.com>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
Date: Sun, 8 Jul 2007 12:00:55 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0707081158340.31544@woody.linux-foundation.org> (raw)
In-Reply-To: <20070708185118.GL21668@ftp.linux.org.uk>
On Sun, 8 Jul 2007, Al Viro wrote:
>
> I think that we need to go the other way round - gather nameidata
> ->nd and ->dentry into struct path and pass pointer to that instead...
Yeah, that sounds fine too.
> But that's .23-rc1 fodder, if not .23-rc2 one (we might want to
> do -rc2 with just that, to avoid conflicts with pending patches).
> Definitely not for .22-final.
Oh, absolutely. I wasn't implying that we would want to do it today, but
as it is now, just looking at that code makes my eyes water.. So it would
be nice to fix that up.
One reason I would almost prefer an "nd", though, is that it would allow
us to in general always just convert anythign that now looks up a path to
look up "a path or file descriptor" instead. Those things need "nd" right
now, and if it's a "struct path", then you'll always have the two
different cases, rather than just the common "release_nd()" at the end.
Linus
next prev parent reply other threads:[~2007-07-08 19:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 5:14 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Markus Trippelsdorf
2007-07-08 8:20 ` Andrew Morton
2007-07-08 10:09 ` Markus Trippelsdorf
2007-07-08 15:28 ` 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result Markus Trippelsdorf
2007-07-08 17:02 ` Linus Torvalds
2007-07-08 17:06 ` Ulrich Drepper
2007-07-08 17:33 ` Markus Trippelsdorf
2007-07-08 17:34 ` Al Viro
2007-07-08 17:41 ` Ulrich Drepper
2007-07-08 18:12 ` Linus Torvalds
2007-07-08 18:24 ` Ulrich Drepper
2007-07-08 18:31 ` Al Viro
2007-07-08 18:40 ` Linus Torvalds
2007-07-08 18:30 ` Linus Torvalds
2007-07-08 18:34 ` Al Viro
2007-07-08 18:38 ` Linus Torvalds
2007-07-08 18:51 ` Al Viro
2007-07-08 19:00 ` Linus Torvalds [this message]
2007-07-08 19:26 ` Al Viro
2007-07-08 18:19 ` Al Viro
2007-07-09 12:40 ` 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Lenar Lõhmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0707081158340.31544@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®