mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: James Morris <jmorris@namei.org>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	Paul Moore <paul.moore@hp.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] SELinux Netlabel updates
Date: Tue, 17 Jul 2007 17:46:39 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707171745180.27353@woody.linux-foundation.org> (raw)
In-Reply-To: <469D6135.4000301@googlemail.com>



On Wed, 18 Jul 2007, Michal Piotrowski wrote:
> 
> Once again I tested both patches, build log shows only this

You clearly didn't test them with CONFIG_NETLABEL set to off, or you have 
a buggy compiler.

You had

	int netlbl_enabled(void)
	{
		return 0;
	}

in a header file.

Now think for a moment what happens when that header file gets included 
multiple times from different C files?

		Linus

  reply	other threads:[~2007-07-18  0:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17 23:48 James Morris
2007-07-17 23:48 ` [PATCH 1/2] SELinux: enable dynamic activation/deactivation of NetLabel/SELinux enforcement James Morris
2007-07-17 23:49 ` [PATCH 2/2] SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel James Morris
2007-07-18  0:24 ` [PATCH 0/2] SELinux Netlabel updates Linus Torvalds
2007-07-18  0:39   ` Michal Piotrowski
2007-07-18  0:46     ` Linus Torvalds [this message]
2007-07-18  1:53   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707171745180.27353@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=paul.moore@hp.com \
    --cc=sds@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®