mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Satyam Sharma <satyam@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Daniel Walker <dwalker@mvista.com>,
	Roman Zippel <zippel@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	peterz@infradead.org
Subject: Re: [ANNOUNCE/RFC] Really Fair Scheduler
Date: Sun, 2 Sep 2007 14:10:37 +0530 (IST)	[thread overview]
Message-ID: <alpine.LFD.0.999.0709021349290.22654@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <20070902072029.GA24427@elte.hu>



On Sun, 2 Sep 2007, Ingo Molnar wrote:
> 
> Although it _should_ have been a net code size win, because if you look 
> at the diff you'll see that other useful things were removed as well: 
> sleeper fairness, CPU time distribution smarts, tunings, scheduler 
> instrumentation code, etc.

To be fair to Roman, he probably started development off an earlier CFS,
most probably 2.6.23-rc3-git1, if I guess correctly from his original
posting. So it's likely he missed out on some of the tunings/comments(?)
etc code that got merged after that.

> > I also ran hackbench (in a haphazard way) a few times on it vs. CFS in 
> > my tree, and RFS was faster to some degree (it varied)..
> 
> here are some actual numbers for "hackbench 50" on -rc5, 10 consecutive 
> runs fresh after bootup, Core2Duo, UP:

Again, it would be interesting to benchmark against 2.6.23-rc3-git1. And
also probably rediff vs 2.6.23-rc3-git1 and compare how the code actually
changed ... but admittedly, doing so would be utterly pointless, because
much water has flowed down the Ganges since -rc3 (misc CFS improvements,
Peter's patches that you mentioned). So a "look, I told you so" kind of
situation wouldn't really be constructive at all.

> It would be far more reviewable and objectively judgeable on an item by 
> item basis if Roman posted the finegrained patches i asked for. (which 
> patch series should be sorted in order of intrusiveness - i.e. leaving 
> the harder changes to the end of the series.)

Absolutely. And if there indeed are net improvements (be it for corner
cases) over latest CFS-rc5, while maintaining performance for the common
cases at the same time, well, that can only be a good thing.

Just my Rs. 0.02,

Satyam

  reply	other threads:[~2007-09-02  8:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31  2:05 Roman Zippel
2007-08-31  9:36 ` Mike Galbraith
2007-08-31 13:22   ` Roman Zippel
2007-08-31 13:55     ` Mike Galbraith
2007-09-01  4:35     ` Mike Galbraith
2007-08-31 10:54 ` Ingo Molnar
2007-08-31 13:19   ` Roman Zippel
2007-09-02  9:26     ` Ingo Molnar
2007-09-03  2:58       ` Roman Zippel
2007-09-06  3:03         ` Syren Baran
2007-09-01  6:48   ` Roman Zippel
2007-09-02  2:19     ` Bill Davidsen
2007-09-02 17:02       ` Roman Zippel
2007-09-02  0:52 ` Daniel Walker
2007-09-02  7:20   ` Ingo Molnar
2007-09-02  8:40     ` Satyam Sharma [this message]
2007-09-02  9:59       ` Ingo Molnar
2007-09-02 15:16     ` Roman Zippel
2007-09-02 15:29       ` Ingo Molnar
2007-09-02 17:16         ` Roman Zippel
2007-09-02 19:21           ` Ingo Molnar
2007-09-07 15:35     ` Roman Zippel
2007-09-08  7:56       ` Mike Galbraith
2007-09-08  8:23         ` Mike Galbraith
2007-09-10 23:23         ` Roman Zippel
2007-09-11  6:18           ` Mike Galbraith
2007-09-11 11:28             ` Roman Zippel
2007-09-02 14:47   ` Roman Zippel
2007-09-02 15:00     ` Daniel Walker
2007-09-03 18:20       ` Roman Zippel
2007-09-03 21:06         ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0709021349290.22654@enigma.security.iitk.ac.in \
    --to=satyam@infradead.org \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®