From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Duane Griffin <duaneg@dghda.com>,
linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning
Date: Wed, 31 Oct 2007 08:59:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710310854560.3340@woody.linux-foundation.org> (raw)
In-Reply-To: <20071031151934.GA19211@wotan.suse.de>
On Wed, 31 Oct 2007, Nick Piggin wrote:
>
> Well the patch is right, in the context of the regression I introduced
> (and so it should probably go into 2.6.23).
Yeah, it probably is fine for -stable.
And if mine (which actually changes behaviour, in that it makes ptrace get
an access error) causes regressions, I guess we'll have to use that
compatible-with-old-behaviour one for 2.6.24 too.
But I just rebooted and tested - the cleaned-up patch does seem to work
fine, and I get "Cannot access memory at address <xyz>" rather than any
reported problem.
So I think I'll commit my version asap, and see if anybody reports that
they have a situation where they use ptrace() and expect zero back from a
shared mapping past the end.. And if there are issues, we can switch back
to the old broken behaviour with your patch,
Linus
next prev parent reply other threads:[~2007-10-31 16:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 0:45 Duane Griffin
2007-10-31 4:19 ` Nick Piggin
2007-10-31 10:27 ` Duane Griffin
2007-10-31 15:11 ` Linus Torvalds
2007-10-31 15:19 ` Nick Piggin
2007-10-31 15:59 ` Linus Torvalds [this message]
2007-10-31 17:19 ` Duane Griffin
2007-10-31 22:55 ` Nick Piggin
2007-10-31 23:08 ` Linus Torvalds
2007-11-01 2:37 ` Nick Piggin
2007-11-01 15:14 ` Linus Torvalds
2007-11-01 15:47 ` Nick Piggin
2007-11-01 16:08 ` Linus Torvalds
2007-11-01 23:56 ` Nick Piggin
2007-11-02 1:17 ` Linus Torvalds
2007-11-02 6:30 ` Nick Piggin
2007-10-31 6:42 ` Nick Piggin
2007-10-31 6:56 ` David Miller
2007-10-31 7:41 ` Nick Piggin
2007-10-31 7:44 ` David Miller
2007-11-02 5:02 ` David Miller
2007-11-02 10:45 ` Nick Piggin
2007-11-02 15:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710310854560.3340@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=duaneg@dghda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®