From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
David Holmes - Sun Microsystems <David.Holmes@Sun.COM>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix for futex_wait signal stack corruption
Date: Tue, 4 Dec 2007 13:09:36 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.0.9999.0712041307270.32379@woody.linux-foundation.org> (raw)
In-Reply-To: <1196801858.1645.37.camel@localhost.localdomain>
On Tue, 4 Dec 2007, Steven Rostedt wrote:
>
> The solution I did to solve this is to allocate a temporary buffer when
> setting up the block and free it in futex_wait_restart. This patch
> allows David's test program to actually pass.
No. Unacceptable. This is a memory leak in case nobody retries it. It's
basically not how you can do this thing.
The *only* thing you can pass for a system call restart is the argument
block register state. If that is not enough, then you cannot restart it.
It's that simple.
Andrew, please do *not* put this in any queues. It's fundamentally broken,
and cannot be fixed as is.
Linus
next prev parent reply other threads:[~2007-12-04 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 20:57 Steven Rostedt
2007-12-04 21:09 ` Linus Torvalds [this message]
2007-12-04 21:39 ` Steven Rostedt
2007-12-04 22:43 ` Linus Torvalds
2007-12-05 1:23 ` Steven Rostedt
2007-12-05 1:46 ` Linus Torvalds
2007-12-05 3:17 ` [PATCH -v2] " Steven Rostedt
2007-12-05 3:41 ` Linus Torvalds
2007-12-05 3:47 ` Randy Dunlap
2007-12-05 3:53 ` Steven Rostedt
2007-12-05 5:33 ` David Holmes - Sun Microsystems
2007-12-05 6:06 ` Linus Torvalds
2007-12-05 6:14 ` David Holmes - Sun Microsystems
2007-12-05 5:54 ` Thomas Gleixner
2007-12-05 10:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.9999.0712041307270.32379@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=David.Holmes@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®