From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Adrian Bunk <bunk@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: is "pci_find_subsys" safe to remove?
Date: Tue, 26 Feb 2008 04:27:25 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.1.00.0802260427030.27140@localhost.localdomain> (raw)
In-Reply-To: <20080226091935.GB3498@cs181133002.pp.htv.fi>
On Tue, 26 Feb 2008, Adrian Bunk wrote:
> On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
> >
> > it's not just that it falls under the category of PCI "legacy" but,
> > if you look in drivers/pci/search.c near the bottom:
> >
> > ...
> > #ifdef CONFIG_PCI_LEGACY
> > EXPORT_SYMBOL(pci_find_device);
> > EXPORT_SYMBOL(pci_find_slot);
> > #endif /* CONFIG_PCI_LEGACY */
> > ...
> >
> > that symbol is not being exported even *if* you select PCI_LEGACY.
> > i'm guessing that's an oversight but it would certainly suggest that
> > no one can possibly be using it, no?
>
> It's used by pci_find_device().
yes, i noticed that shortly after hitting the ENTER key. sigh. it
was a long day ...
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================
prev parent reply other threads:[~2008-02-26 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 22:15 Robert P. J. Day
2008-02-26 9:19 ` Adrian Bunk
2008-02-26 9:27 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0802260427030.27140@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®