is "pci_find_subsys" safe to remove?

is "pci_find_subsys" safe to remove?

[Robert P. J. Day]

  it's not just that it falls under the category of PCI "legacy" but,
if you look in drivers/pci/search.c near the bottom:

...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /* CONFIG_PCI_LEGACY */
...

that symbol is not being exported even *if* you select PCI_LEGACY.
i'm guessing that's an oversight but it would certainly suggest that
no one can possibly be using it, no?

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

Re: is "pci_find_subsys" safe to remove?

[Adrian Bunk]

On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
> 
>   it's not just that it falls under the category of PCI "legacy" but,
> if you look in drivers/pci/search.c near the bottom:
> 
> ...
> #ifdef CONFIG_PCI_LEGACY
> EXPORT_SYMBOL(pci_find_device);
> EXPORT_SYMBOL(pci_find_slot);
> #endif /* CONFIG_PCI_LEGACY */
> ...
> 
> that symbol is not being exported even *if* you select PCI_LEGACY.
> i'm guessing that's an oversight but it would certainly suggest that
> no one can possibly be using it, no?

It's used by pci_find_device().

> rday

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: is "pci_find_subsys" safe to remove?

[Robert P. J. Day]

On Tue, 26 Feb 2008, Adrian Bunk wrote:

> On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
> >
> >   it's not just that it falls under the category of PCI "legacy" but,
> > if you look in drivers/pci/search.c near the bottom:
> >
> > ...
> > #ifdef CONFIG_PCI_LEGACY
> > EXPORT_SYMBOL(pci_find_device);
> > EXPORT_SYMBOL(pci_find_slot);
> > #endif /* CONFIG_PCI_LEGACY */
> > ...
> >
> > that symbol is not being exported even *if* you select PCI_LEGACY.
> > i'm guessing that's an oversight but it would certainly suggest that
> > no one can possibly be using it, no?
>
> It's used by pci_find_device().

yes, i noticed that shortly after hitting the ENTER key.  sigh.  it
was a long day ...

rday
--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================